Fold the settlement and reservation shape into the Effect Truth issues

[George-RD]

Part of #182

Question

Comment the review's shape notes onto #173 and #174 so the Effect Truth track carries them:

• the typed EffectOutcome seed at the executor seam (api/effect_executors.rs) and where it is re-collapsed into DispatchError/anyhow (api/scoped_admission.rs:526-539);
• settlement policy living inline in the ~940-line mediate implementation, with three parallel string-keyed fan-outs;
• the reservation as a bare (String, u32, String) tuple in four modules, wanting one named domain type;
• the dead EgressClassifier parameter on gate() (zero adapters), deletable in the same track.

Users carried: Lyra, Bell, Unattended workhorse, Auditor. Promise: Ledger. Evidence: review, candidates 1 and 7.

Resolved when the comments are posted and linked from this ticket.

[George-RD]

Resolution. Folded. Shape notes posted: #173 (comment) and #174 (comment). The Effect Truth track now carries the settlement-module direction, the typed-reservation step, and the dead EgressClassifier deletion.

[coderabbitai]

Coding Plan

Summary

• Treat the ticket as an issue-tracking task: record review shape notes on the Effect Truth issues, not a code change.
• Verify all four notes against current code and the review evidence before posting, so the references are accurate.
• Split the notes by theme across #173 and #174 after reading each issue's scope, and post them with gh issue comment using body files.
• Link the posted comment URLs from this ticket and close it, satisfying the stated resolution condition.

Design Choices

Design Choice 1: Which shape notes belong on `#173` versus `#174`?

Options Considered:

1. Post all four notes on both issues (full duplication).
2. Split by theme: post the EffectOutcome seam note (executor truth collapse) on the issue that owns the effect-outcome seam, and post the settlement-policy, reservation-tuple, and EgressClassifier notes on the issue that owns mediation/reservation cleanup.
3. Post all four notes on one issue and a cross-link on the other.

Chosen Option: 2

Rationale: The four notes divide cleanly into an "effect outcome truth" concern and a "mediation/reservation shape and cleanup" concern, so a themed split keeps each issue focused. Confirm the exact mapping by reading each issue with gh issue view before posting. Fall back to Option 1 only if the issue scopes do not match the split.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Phase 1: Verify and assemble the shape notes

This phase confirms that every claim in the four notes is still accurate and gathers the exact code references. Accurate references make the recorded notes trustworthy for the later Effect Truth work.

Task 1: Confirm issue scope and current claim status

Read the target issues and confirm how to split the notes.

• Run gh issue view 173 and gh issue view 174 to read titles, bodies, and existing comments.
• Confirm which issue owns the effect-outcome seam and which owns mediation and reservation cleanup.
• Record the chosen note-to-issue mapping from the Assumptions section, or adjust it if the issue scopes require a different split.
• Confirm this ticket is Part of Wayfinder map: the deepening route — from the 2026-08-20 review to designed specs #182`` and note its own issue number for the later link-back step.

Task 2: Verify the four shape notes against current code

Re-check each note so the recorded references are correct.

• Confirm the EffectOutcome enum and executor contract in crates/openspine-kernel/src/api/effect_executors.rs, including the four variants Executed, RefusedPreEffect, DeliveryUnknown, and FailedAfterAttempt.
• Confirm the collapse into DispatchError/anyhow in crates/openspine-kernel/src/api/scoped_admission.rs and validate the cited line range 526-539. Note that RefusedPreEffect and FailedAfterAttempt both map to DispatchError::Connector.
• Confirm the ~940-line mediate_and_dispatch_action_with_attribution_and_token in crates/openspine-kernel/src/api/actions.rs and the three parallel reservation trackers (consult_reservation, fired_reservation, disclosure_reservations).
• Confirm the bare (String, u32, String) reservation tuple in the four modules: disclosure.rs, api/scoped_admission.rs, api/actions.rs, and store/standing_rules_fired_token.rs. Record that the three fields mean rule_id, version, and reservation_id.
• Confirm the dead _egress: &dyn EgressClassifier parameter on gate()/resolve() in crates/openspine-gate/src/gate.rs. Confirm no call path invokes .classify() through the trait object.
• Cross-check all claims against .raw/openspine-architecture-review-2026-08-20.md, candidates 1 and 7.

🤖 Prompt for AI agents

This phase is a verification and information-gathering phase for an
issue-tracking task. There is no code change in this phase.

- Run `gh issue view 173` and `gh issue view 174` to read titles, bodies, and
existing comments.
- Determine which issue owns the effect-outcome seam concern and which owns
mediation and reservation cleanup.
- Apply the chosen note-to-issue mapping from the assumptions, and adjust it
only if the actual issue scopes require a different split.
- Confirm this ticket is `Part of `#182``, and note this ticket's own issue number
for later use in the link-back step.
- Verify the `EffectOutcome` enum and executor contract in
`crates/openspine-kernel/src/api/effect_executors.rs`. Confirm the four
variants: `Executed`, `RefusedPreEffect`, `DeliveryUnknown`, and
`FailedAfterAttempt`.
- Verify the collapse into `DispatchError`/`anyhow` in
`crates/openspine-kernel/src/api/scoped_admission.rs`, and validate the cited
line range `526-539`. Note that both `RefusedPreEffect` and `FailedAfterAttempt`
map to `DispatchError::Connector`.
- Verify the ~940-line `mediate_and_dispatch_action_with_attribution_and_token`
function in `crates/openspine-kernel/src/api/actions.rs`, and the three parallel
reservation trackers: `consult_reservation`, `fired_reservation`, and
`disclosure_reservations`.
- Verify the bare `(String, u32, String)` reservation tuple appears in all four
modules: `disclosure.rs`, `api/scoped_admission.rs`, `api/actions.rs`, and
`store/standing_rules_fired_token.rs`. Record that the three tuple fields mean
`rule_id`, `version`, and `reservation_id`.
- Verify the dead `_egress: &dyn EgressClassifier` parameter on
`gate()`/`resolve()` in `crates/openspine-gate/src/gate.rs`, and confirm no call
path invokes `.classify()` through the trait object.
- Cross-check every claim against
`.raw/openspine-architecture-review-2026-08-20.md`, candidates 1 and 7, to
ensure accuracy before drafting comments.

Phase 2: Post the comments to the Effect Truth issues

This phase writes and posts the comments. Each comment states the shape problem, the exact code location, and the intended future shape, without prescribing the implementation.

Task 1: Compose the comment text

Draft the note text for each target issue.

• For the effect-outcome note, describe the typed EffectOutcome seed at the executor seam and its re-collapse into DispatchError/anyhow. Cite api/effect_executors.rs and api/scoped_admission.rs:526-539. State that the collapse loses the distinction between RefusedPreEffect and FailedAfterAttempt.
• For the settlement-policy note, describe settlement policy living inline in the ~940-line mediate implementation with three parallel string-keyed fan-outs. Cite api/actions.rs.
• For the reservation-shape note, describe the bare (String, u32, String) tuple in the four modules and the wish for one named domain type (rule_id, version, reservation_id). Cite the four files.
• For the EgressClassifier note, describe the dead _egress parameter on gate() with zero real adapters, and mark it deletable in the same track. Cite crates/openspine-gate/src/gate.rs.
• Include in each comment the carried users (Lyra, Bell, Unattended workhorse, Auditor), the Ledger promise, and the evidence link to the review (candidates 1 and 7).
• Keep each note as a shape observation for later work. Do not include code fixes.

Task 2: Post the comments

Post the composed notes to the two issues.

• Post the effect-outcome seam note to its assigned issue with gh issue comment <n> --body-file <file>.
• Post the settlement-policy, reservation-shape, and EgressClassifier notes to their assigned issue with gh issue comment <n> --body-file <file>.
• Use body files rather than inline strings so the code references and links stay intact.
• Capture the returned comment URLs for the link-back step.

🤖 Prompt for AI agents

This phase drafts and posts the shape-note comments to the two Effect Truth
issues (`#173` and `#174`). No source code changes occur in this phase.

- Draft the effect-outcome note: describe the typed `EffectOutcome` seed at the
executor seam and its re-collapse into `DispatchError`/`anyhow`. Cite
`api/effect_executors.rs` and `api/scoped_admission.rs:526-539`. State that the
collapse loses the distinction between `RefusedPreEffect` and
`FailedAfterAttempt`.
- Draft the settlement-policy note: describe settlement policy living inline in
the ~940-line mediate implementation with three parallel string-keyed fan-outs.
Cite `api/actions.rs`.
- Draft the reservation-shape note: describe the bare `(String, u32, String)`
tuple in the four modules, and state the wish for one named domain type with
fields `rule_id`, `version`, and `reservation_id`. Cite the four files:
`disclosure.rs`, `api/scoped_admission.rs`, `api/actions.rs`, and
`store/standing_rules_fired_token.rs`.
- Draft the `EgressClassifier` note: describe the dead `_egress` parameter on
`gate()` with zero real adapters, and mark it deletable in the same track. Cite
`crates/openspine-gate/src/gate.rs`.
- In each comment, include the carried users (Lyra, Bell, Unattended workhorse,
Auditor), the Ledger promise, and the evidence link to
`.raw/openspine-architecture-review-2026-08-20.md` (candidates 1 and 7).
- Keep each note as a shape observation only. Do not include code fixes in any
note.
- Post the effect-outcome seam note to its assigned issue using `gh issue
comment <n> --body-file <file>`.
- Post the settlement-policy, reservation-shape, and `EgressClassifier` notes to
their assigned issue using `gh issue comment <n> --body-file <file>`.
- Use body files, not inline strings, so code references and links stay intact.
- Capture the returned comment URLs for use in the link-back step in Phase 3.

Phase 3: Link and resolve

This phase links the posted comments from this ticket and closes it, which is the stated resolution condition.

Task 1: Link the comments from this ticket

Record the comment URLs on this ticket.

• Add a comment to this ticket that lists the two (or more) posted comment URLs from #173 and #174.
• State which shape notes landed on which issue.
• Keep the Part of Wayfinder map: the deepening route — from the 2026-08-20 review to designed specs #182`` relationship visible in the link comment.

Task 2: Resolve this ticket

Close the ticket per the resolution condition.

• Confirm the comments are posted and linked.
• Close this ticket with gh issue close and a short resolving comment that points to the linked notes.

🤖 Prompt for AI agents

This phase links the posted comments back to this ticket and then resolves the
ticket.

- Add a comment to this ticket that lists all posted comment URLs from `#173` and
`#174`.
- In the link comment, state which shape notes landed on which issue.
- Keep the `Part of `#182`` relationship visible in the link comment.
- Confirm the comments are posted and linked before closing.
- Close this ticket using `gh issue close`, with a short resolving comment that
points to the linked notes.

Research

The repository uses a GitHub Issues workflow driven by the gh CLI. This workflow is documented in docs/agents/issue-tracker.md. That file defines comment, view, and wayfinding conventions, such as map/child issues, Part of #<map> linking, and claim/resolve steps.

The four shape notes describe existing kernel code:

• The typed EffectOutcome at the executor seam (crates/openspine-kernel/src/api/effect_executors.rs) and its collapse in crates/openspine-kernel/src/api/scoped_admission.rs.
• The ~940-line mediate_and_dispatch_action_with_attribution_and_token in crates/openspine-kernel/src/api/actions.rs.
• The bare (String, u32, String) reservation tuple in disclosure.rs, api/scoped_admission.rs, api/actions.rs, and store/standing_rules_fired_token.rs.
• The dead EgressClassifier parameter on gate() in crates/openspine-gate/src/gate.rs.

The source evidence for these notes is .raw/openspine-architecture-review-2026-08-20.md (candidates 1 and 7).

No source-code edits are required by this ticket.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

This phase is a verification and information-gathering phase for an
issue-tracking task. There is no code change in this phase.

- Run `gh issue view 173` and `gh issue view 174` to read titles, bodies, and
existing comments.
- Determine which issue owns the effect-outcome seam concern and which owns
mediation and reservation cleanup.
- Apply the chosen note-to-issue mapping from the assumptions, and adjust it
only if the actual issue scopes require a different split.
- Confirm this ticket is `Part of `#182``, and note this ticket's own issue number
for later use in the link-back step.
- Verify the `EffectOutcome` enum and executor contract in
`crates/openspine-kernel/src/api/effect_executors.rs`. Confirm the four
variants: `Executed`, `RefusedPreEffect`, `DeliveryUnknown`, and
`FailedAfterAttempt`.
- Verify the collapse into `DispatchError`/`anyhow` in
`crates/openspine-kernel/src/api/scoped_admission.rs`, and validate the cited
line range `526-539`. Note that both `RefusedPreEffect` and `FailedAfterAttempt`
map to `DispatchError::Connector`.
- Verify the ~940-line `mediate_and_dispatch_action_with_attribution_and_token`
function in `crates/openspine-kernel/src/api/actions.rs`, and the three parallel
reservation trackers: `consult_reservation`, `fired_reservation`, and
`disclosure_reservations`.
- Verify the bare `(String, u32, String)` reservation tuple appears in all four
modules: `disclosure.rs`, `api/scoped_admission.rs`, `api/actions.rs`, and
`store/standing_rules_fired_token.rs`. Record that the three tuple fields mean
`rule_id`, `version`, and `reservation_id`.
- Verify the dead `_egress: &dyn EgressClassifier` parameter on
`gate()`/`resolve()` in `crates/openspine-gate/src/gate.rs`, and confirm no call
path invokes `.classify()` through the trait object.
- Cross-check every claim against
`.raw/openspine-architecture-review-2026-08-20.md`, candidates 1 and 7, to
ensure accuracy before drafting comments.
===============================================================================

Task: 2

This phase drafts and posts the shape-note comments to the two Effect Truth
issues (`#173` and `#174`). No source code changes occur in this phase.

- Draft the effect-outcome note: describe the typed `EffectOutcome` seed at the
executor seam and its re-collapse into `DispatchError`/`anyhow`. Cite
`api/effect_executors.rs` and `api/scoped_admission.rs:526-539`. State that the
collapse loses the distinction between `RefusedPreEffect` and
`FailedAfterAttempt`.
- Draft the settlement-policy note: describe settlement policy living inline in
the ~940-line mediate implementation with three parallel string-keyed fan-outs.
Cite `api/actions.rs`.
- Draft the reservation-shape note: describe the bare `(String, u32, String)`
tuple in the four modules, and state the wish for one named domain type with
fields `rule_id`, `version`, and `reservation_id`. Cite the four files:
`disclosure.rs`, `api/scoped_admission.rs`, `api/actions.rs`, and
`store/standing_rules_fired_token.rs`.
- Draft the `EgressClassifier` note: describe the dead `_egress` parameter on
`gate()` with zero real adapters, and mark it deletable in the same track. Cite
`crates/openspine-gate/src/gate.rs`.
- In each comment, include the carried users (Lyra, Bell, Unattended workhorse,
Auditor), the Ledger promise, and the evidence link to
`.raw/openspine-architecture-review-2026-08-20.md` (candidates 1 and 7).
- Keep each note as a shape observation only. Do not include code fixes in any
note.
- Post the effect-outcome seam note to its assigned issue using `gh issue
comment <n> --body-file <file>`.
- Post the settlement-policy, reservation-shape, and `EgressClassifier` notes to
their assigned issue using `gh issue comment <n> --body-file <file>`.
- Use body files, not inline strings, so code references and links stay intact.
- Capture the returned comment URLs for use in the link-back step in Phase 3.
===============================================================================

Task: 3

This phase links the posted comments back to this ticket and then resolves the
ticket.

- Add a comment to this ticket that lists all posted comment URLs from `#173` and
`#174`.
- In the link comment, state which shape notes landed on which issue.
- Keep the `Part of `#182`` relationship visible in the link comment.
- Confirm the comments are posted and linked before closing.
- Close this ticket using `gh issue close`, with a short resolving comment that
points to the linked notes.

💡 Iterate on the plan with: `@coderabbitai` <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!