refactor(host): break the Api↔Stats namespace cycle (gh-#445, 1 of 2) - #504
Merged
Conversation
DockerContainerStatsSource returned Api-namespace DTOs (the gh-#148 shape), closing a Host Api↔Stats namespace cycle. Move the two DTOs into Stats so Api→Stats stays one-directional; type names and JSON shapes unchanged. Deletes the Host row from the gh-#445 baseline — shrink-to-fit. The Core Events↔Abstractions row stays for its own sibling PR (that fix touches the published Abstractions surface).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First half of #445 (the split is deliberate — see the sibling PR for why).
🔴 Cycle 2 — Host
Api ↔ Stats:DockerContainerStatsSourcereturned Api-namespace DTOs (the gh-#148 shape).ContainerStatsReportDto+ContainerStatDtomove intoStats(git mv, namespace only) so Api→Stats stays one-directional. Type names and JSON shapes unchanged — wire-compatible. Also unblocks the F105.4 graduation note in the issue (a subsystem in a cycle can't leave Host).📉 Baseline shrinks 2→1: the Host row is deleted; the Core row survives until the sibling PR. Purely internal — zero published-package impact, safe to merge any time.
✅
dotnet build GenWave.slnzero warnings; Architecture.Tests 104/104 (cycle guard + every other law); Host.Tests container-filtered 32 passed / 0 failed (13 pre-existing compose-integration skips).