feat(booth-log): LLM call rows carry the authoring persona's name (gh-#429) - #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #429 — personas drive the copy; now the call inspector says which one. 🎤
LlmCallRecord/LlmCallRing.Record/LlmCallDto/LlmCallEntrywidened withpersonaName; resolved once, up front inRequestCompletionAsyncvia the existingLlmPromptBuilder.ResolveNameprecedence (madeinternal, not duplicated), so success AND failure records carry it — a call that faults before prompt assembly still names its author.—on null per the feed's own convention. Preview rows carry the override persona's name (card:null by design there).Verification: 3 new ring facts (success / failure / no-persona-null) reading
Snapshot()directly, the Story196 wire-mirror pinned to the real name flowing through the pipeline, 2 new jest specs on the feed;tsc --noEmitclean; full suite in a clean worktree 3,610 passed / 0 failed, build 0 warnings. Built by a worktree builder; reviewed + full-suite re-verified before PR.