test(arch): namespace cycle-freedom guard + baseline of the two live cycles (gh-#445) - #446
Merged
Merged
Conversation
…ycles (gh-#445) Slices every project by first namespace segment, requires cycle freedom. Two pre-existing tangles (Core Events<->Abstractions, Host Api<->Stats) ship as a named, dated, shrink-to-fit baseline: a fixed cycle turns its row stale-red until deleted. Deliberately not a LawId — promotion to L7 (CONTRIBUTING row + parity) is gh-#445's recorded /design step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dean's question — is cyclic-dependency coverage part of the arch rules? — answered: it wasn't, and the new guard immediately found two live cycles (details + fix sketches on #445).
What ships
Gh445_NamespaceCycleFreedom: ArchUnitNET slice rule per project (first namespace segment below the root),BeFreeOfCycles, evaluated via the suite's hand-rolled-assert house pattern (core package only — no new dependency).Events -> Abstractionsand HostApi -> Statsare named/dated rows; a NEW cycle anywhere fails with the full cycle text, and fixing a baselined cycle also fails — with a 🎉 — until its row is deleted. Debt can only shrink.LawId: law adoption = CONTRIBUTING law-table row + parity updates = a /design ruling, recorded on arch: two namespace cycles found by the new cycle-freedom guard — Core Events↔Abstractions, Host Api↔Stats #445 for when the slate is clean.Verification
Architecture suite 95/95 green (was 87; +8 theories). Pre-baseline the rule failed exactly 2/8 projects with the two real cycles — that red run is what populated the baseline.