feat(icecast): stream access+error logs to stdout/stderr for the Loki tailer (gh-#115) - #222
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115 (P1).
One-file diff:
icecast.xml.tmplsets<accesslog>-</accesslog>+<errorlog>-</errorlog>. Our pinned icecast is 2.5.0, which supports-for BOTH logs (v2.5.0 source:main.c:361errorlog,main.c:382-383accesslog →log_open_file(stderr)) — unlike early 2.4.x, so no nginx-style symlink needed. Rotation applies only to the file branch (nothing to neutralize), andrestart_loggingskips reopen for-logs, so it's HUP-safe (verified live: SIGHUP reload, access lines kept flowing).🔬 Local evidence (built + ran the image, curled 200 + 404 — from
docker logs):Log dir empty before and after HUP — nothing grows on disk. Story221 icecast pins untouched (3/3 pass).
🚀 Ships with the next image release (v2.8.5+). Fleet acceptance after deploy:
{station="demo", service="icecast"}shows listener connect/disconnect + mount events in steady state; the alloyservice="icecast"label contract is unaffected.