-
Notifications
You must be signed in to change notification settings - Fork 1
feat: fleet-at-a-glance dashboard redesign #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
784a534
feat: redesign dashboard as fleet-at-a-glance monitoring view
GeiserX 9e780cf
fix: resolve Settings icon import clash with android.provider.Settings
GeiserX 52a9fa4
fix: resolve dashboard review findings
GeiserX d044d6b
fix: cancel-and-replace overlapping refreshes, eager permission check
GeiserX 3d4fbcb
refactor: extract hardcoded strings to strings.xml for i18n
GeiserX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: GeiserX/CashPilot-android
Length of output: 2580
🏁 Script executed:
Repository: GeiserX/CashPilot-android
Length of output: 6888
🏁 Script executed:
Repository: GeiserX/CashPilot-android
Length of output: 7209
🏁 Script executed:
Repository: GeiserX/CashPilot-android
Length of output: 2142
Pass the freshly computed enabled set into
doRefresh()to avoid stale reads.Line 89 calls
doRefresh()immediately afterSettingsStore.update(...)completes, but line 96 re-readssettings.value.enabledSlugsfrom a StateFlow backed by DataStore. Although the write is persisted whenupdate()returns, the StateFlow may not have emitted the updated value yet. The toggled app can remain in its previous enabled/disabled state until the StateFlow catches up. Capture the computed slug set before storing and pass it todoRefresh(...)to ensure immediate consistency.💡 Example fix
fun toggleApp(slug: String) { viewModelScope.launch { + var enabledAfterToggle: Set<String> = emptySet() SettingsStore.update(getApplication()) { s -> val new = s.enabledSlugs.toMutableSet() if (slug in new) new.remove(slug) else new.add(slug) - s.copy(enabledSlugs = new) + enabledAfterToggle = new.toSet() + s.copy(enabledSlugs = enabledAfterToggle) } - // withContext(IO) yields to main, letting the settings StateFlow update - doRefresh() + doRefresh(enabledAfterToggle) } } -private suspend fun doRefresh() { +private suspend fun doRefresh(enabled: Set<String> = settings.value.enabledSlugs) { _isRefreshing.value = true withContext(Dispatchers.IO) { - val enabled = settings.value.enabledSlugs val detected = detector.detectAll(enabled).associateBy { it.slug }🤖 Prompt for AI Agents