feat: production-harden sidecar with auth, watchdog, and dev workflow - #4
Conversation
- Add cfg!(dev) branch to bypass sidecar spawn and connect to manual Python on port 8765 - Add process watchdog (5s poll, auto-restart up to 3 times) - Replace TCP health check with HTTP GET /health + version handshake - Generate 64-char hex auth token via getrandom, pass as CASHPILOT_AUTH_TOKEN - Switch PyInstaller from onefile to onedir (eliminates 3-7s cold start) - Add conditional Windows code signing steps in CI workflow - Fix banner SVG to use consistent styling for "CashPilot Desktop" - Rewrite README with full service catalog, FAQ, and Desktop vs Web comparison - Add Makefile for dev workflow (dev-backend, dev-tauri, build, test)
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (10)
📝 WalkthroughWalkthroughCashPilot Desktop 0.3.0 adds sidecar authentication with randomly generated tokens, redesigns health checking via HTTP with version validation, implements process restart capability, enables dev-mode external backend connection, adds Windows release signing, and provides expanded development documentation and build tooling. ChangesCashPilot Desktop 0.3.0 Release
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
cfg!(dev)bypasses sidecar spawn, connects to manually-started Python backend on port 8765 (make dev-backend)/healthreturning JSON with version fieldgetrandom, passed to sidecar asCASHPILOT_AUTH_TOKENsidecar/**/*resource globWINDOWS_SIGN_CERT+WINDOWS_SIGN_PASSWORDsecrets)Test plan
cargo buildpassescargo test)make dev-backend+make dev-tauriconnects successfully in dev modeSummary by CodeRabbit
Release Notes
New Features
Improvements
Chores