security: pin all container images to digests + enforce with a catalog test - #37
Conversation
…g test The service catalog pulled every image by a floating tag / bare :latest — a supply-chain risk (closed-source proxyware auto-pulled onto the user's IP) that also violated the repo's own rule (CLAUDE.md: never :latest). Pin all 19 resolvable images to their current multi-arch OCI index digest (image[:tag]@sha256:...); the only unpinned image is peer2profit (dead — its Docker Hub repo was removed), which is exempt as a dead service. Add internal/catalog/image_pin_test.go: loads the real ./services catalog and fails if any non-dead/dropped/broken service with a non-empty docker.image lacks an @sha256: pin. Fail-closed verified. Verified on macOS: go test ./internal/catalog/ + go test ./... green.
|
Warning Review limit reached
Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (21)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 45.95% 50.31% +4.36%
==========================================
Files 8 8
Lines 1754 1751 -3
==========================================
+ Hits 806 881 +75
+ Misses 893 802 -91
- Partials 55 68 +13 🚀 New features to boost your workflow:
|
1 participant
Fourth PR from the
/review-code!audit — the top security finding (S1).The catalog pulled every service image by a floating tag / bare
:latest— a real supply-chain risk (closed-source passive-income clients auto-pulled onto your residential IP) that also broke the repo's own rule (CLAUDE.md: never:latest).image[:tag]@sha256:…, kept the tag for readability, stays multi-platform).peer2profit— its Docker Hub repo was removed (401), and it's adeadservice, so it's exempt.internal/catalog/image_pin_test.goloads the real./servicescatalog and fails if any non-dead/dropped/brokenservice with a non-emptydocker.imagelacks an@sha256:pin. Fail-closed proven (temporarily unpinning one image failed the test).Verified on macOS:
go test ./internal/catalog/+go test ./...green. Renovate/Dependabot can keep the digests fresh going forward.