Skip to content

test(runtime): stop a log-flush race failing the macOS release build #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeiserX merged 1 commit into from
Sep 13, 2026
Merged

test(runtime): stop a log-flush race failing the macOS release build #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions internal/runtime/native_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,19 @@ func TestNativeDeployTarGzExecAndStop(t *testing.T) {
t.Fatal("stub marker never written (binary did not execute)")
}

logs, err := p.Logs(context.Background(), "stubsvc", 100)
if err != nil {
t.Fatalf("Logs: %v", err)
}
if !strings.Contains(logs, "cashpilot-native-stub alive") {
// The stub writes its marker file and its stdout line as two separate events,
// so the marker appearing above does not mean the log has been captured yet.
// Reading once here failed the macOS release build for v0.17.4 on an empty
// log. Every other assertion in this file waits; this one now does too.
var logs string
if !waitFor(t, 5*time.Second, func() bool {
out, err := p.Logs(context.Background(), "stubsvc", 100)
if err != nil {
return false
}
logs = out
return strings.Contains(out, "cashpilot-native-stub alive")
}) {
t.Fatalf("captured logs missing stub output: %q", logs)
}

Expand Down