adds drive_download_contents() method to client#7
Merged
ingmferrer merged 3 commits intoGearPlug:masterfrom Mar 10, 2020
Merged
adds drive_download_contents() method to client#7ingmferrer merged 3 commits intoGearPlug:masterfrom
ingmferrer merged 3 commits intoGearPlug:masterfrom
Conversation
richardARPANET
commented
Jan 7, 2020
| r = response.json() | ||
| else: | ||
| r = response.text | ||
| r = response.content |
Author
There was a problem hiding this comment.
Without this change the file contents returns as a str. When a file is downloaded as str (I tested an xlsx file), it will be corrupted. Changing to response.content returns bytes instead and the downloaded file opens correctly.
added 2 commits
January 9, 2020 20:43
…owser (excel online) and drive attempts to update it at the same time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.microsoft.com/en-us/graph/api/driveitem-get-content?view=graph-rest-beta&tabs=http
The new method returns a
b'file contents'