[LGSM] Text issue when "already stopped"

[marvinlehmann]

Hey,
If I stop my server when it is already stopped the text bugs. I dont know how I should call/name it..
Putty:
[ .... ] Stopping csgo_server: ARES Gaming - Clan Server
(everything is normal but then the line changes)
is already stoppedsgo_server: ARES Gaming - Clan Server

It works, if I change:
servername=$(grep -s hostname "${servercfgfullpath}"|sed 's/hostname //g'|sed 's/"//g')
rcon=$(grep -s rcon_password "${servercfgfullpath}"|sed 's/rcon_password //g'|sed 's/"//g')
to
servername=$(grep -s "hostname" "${servercfgfullpath}" | grep -oP '"\K[^"]+(?=["])')
rcon=$(grep -s "rcon_password" "${servercfgfullpath}" | grep -oP '"\K[^"]+(?=["])')

Sorry but I cant describe this issue in english^^

https://github.com/dgibbs64/linuxgameservers/blob/master/CounterStrikeGlobalOffensive/csgoserver#L580
https://github.com/dgibbs64/linuxgameservers/blob/master/CounterStrikeGlobalOffensive/csgoserver#L75-L76

I'm on Ubuntu 14.04.1 LTS (GNU/Linux 3.13.0-35-generic x86_64)

[dgibbs64]

I haven't seen this issue for a while. Can you post the variables at the top of csgoserver for me. Looks like the servicename has been changed. Not sire if this is causing it. I will have a look at this when I can.

Its not a major issue so I will look at it when I can

Thanks for reporting the issue!

[marvinlehmann]

OK :)
These?

Steam

appid="740"

Server Details

servicename="csgo_server"
gamename="Counter Strike: Global Offensive"
engine="source"

Directorys

rootdir="$(cd "$(dirname "${BASH_SOURCE[0]}" )" && pwd )"
selfname="$0"
lockselfname=$(echo ".${servicename}.lock")
filesdir="${rootdir}/csgo_server"
systemdir="${filesdir}/csgo"
executabledir="${filesdir}"
executable="./srcds_run"
servercfgdir="${systemdir}/cfg"
servercfg="${servicename}.cfg"
servercfgfullpath="${servercfgdir}/${servercfg}"
defaultcfg="${servercfgdir}/server.cfg"
steamclient="${rootdir}/steamcmd/linux32/steamclient.so"

I changed "csgo-server" to "csgo_server", because I used this format for my other servers too.
(I removed the backup function (+path).)

[dgibbs64]

Yeah that's what I'm after. I will look in to this when I can. Thank you :-)

[marvinlehmann]

No problem. I thank you too :P

[dgibbs64]

Im afraid I am unable to replicate at all using Ubuntu 14.04. I will not be making changes in this instance. The issue may have something to do with your install of Ubuntu?

[marvinlehmann]

I finally found the issue. The format of the end of the line (newline). I uploaded my server config from my windows pc (-> CR+LF). When I converted it to unix (-> LF) it is working fine without my "fix". So its an issue on my end. Thanks for this awesome script :)

My fix/workaround:
servername=$(grep -s hostname "${servercfgfullpath}"|sed 's/hostname //g'|sed 's/"//g')
rcon=$(grep -s rcon_password "${servercfgfullpath}"|sed 's/rcon_password //g'|sed 's/"//g')
to
servername=$(grep -s "hostname" "${servercfgfullpath}" | grep -oP '"\K[^"]+(?=["])')
rcon=$(grep -s "rcon_password" "${servercfgfullpath}" | grep -oP '"\K[^"]+(?=["])')

Regards,
Marvin

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.