chore(deps): bump gravity-aptos api-types to 69008fd0 (drop legacy consensusAlpha)#400
Open
nekomoto911 wants to merge 1 commit into
Open
Conversation
Re-pin `gravity-api-types` to Galxe/gravity-aptos#77, which removes the legacy `consensusAlpha` epoch key from the consensus-hardfork framework (Galxe/gravity-audit#925). greth does not use the removed reader (`ConsensusHardforks::from_genesis_extra_fields`), so this is a source-only dependency bump. Lets gravity-sdk link a single `api-types` (this rev == its `gaptos` rev) instead of two incompatible copies when it bumps both together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-pin
gravity-api-typesfromb1f68dc8to69008fd0(Galxe/gravity-aptos#77).gravity-aptos#77 removes the legacy
consensusAlphaepoch key from theconsensus-hardfork framework (deletes
ConsensusHardforks::from_genesis_extra_fields), closing the auditfinding Galxe/gravity-audit#925. greth does not reference that reader or
any
ConsensusHardforktype, so this is a source-only dependency bump —no greth code change.
Why greth needs to move
gravity-sdk pins both
gaptosand (transitively, through greth)api-typesat the same gravity-aptos rev. To pick up #77 it must bumpgaptosto69008fd0; cargo refuses to[patch]the same git URL to adifferent rev, so greth must re-pin
api-typesto the matching rev or theworkspace links two incompatible
api-typescopies. This bump keepsgreth and gaptos in lockstep, as prior bumps did (e.g. #679, #771).
Verification
cargo metadata --lockedpasses — the lockfile is consistent with the new rev (api-types' dependency set is unchanged by [feat] add metric when insert txn #77).Ref: Galxe/gravity-audit#925, Galxe/gravity-aptos#77