Bump Meziantou.Analyzer to version 3.0.105 and refactor parsing methods#27
Merged
Conversation
Bumps Meziantou.Analyzer from 3.0.104 to 3.0.105 --- updated-dependencies: - dependency-name: Meziantou.Analyzer dependency-version: 3.0.105 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: analyzers ... Signed-off-by: dependabot[bot] <support@github.com>
…alue parsing methods
…lop/analyzers-d09dba7c20 Bump the analyzers group with 1 update
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 97.39% 97.43% +0.03%
==========================================
Files 43 43
Lines 1307 1323 +16
Branches 199 199
==========================================
+ Hits 1273 1289 +16
Misses 9 9
Partials 25 25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Benchmark ResultsMeasured on Benchmarks.Perf.AsyncReaderBenchmarks
Benchmarks.Perf.ByteReaderBenchmarks
Benchmarks.Perf.ByteReaderPoolingBenchmarks
Benchmarks.Perf.ByteReaderStreamBenchmarks
Benchmarks.Perf.ParserBenchmarks
Benchmarks.Perf.PipeReaderBenchmarks
Benchmarks.Perf.ReaderBenchmarks
Benchmarks.Perf.ReaderStartupBenchmarks
Benchmarks.Perf.SourceGenParserBenchmarks
Benchmarks.Perf.WriterBenchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how fallback parsers are created in both the
ColumnParserFactoryandUtf8ColumnParserFactoryby replacing the allocation of delegate-based value parsers with direct calls to static-abstractTryParsemethods. This change reduces indirection and improves performance by allowing the JIT to inline these calls and avoid unnecessary delegate allocations. The shared factory logic is updated accordingly, and some minor cleanup is performed.Parser construction and performance improvements:
BuildParsablemethods in bothColumnParserFactoryandUtf8ColumnParserFactory. These methods generate column parsers that call the static-abstractTryParsedirectly, reducing one level of indirection and avoiding delegate allocation. [1] [2] [3] [4]ColumnParserFactoryShared.Createmethod to use the newBuildParsableapproach for fallback parsing, only using the registry and generic builder for registered (custom) parsers. [1] [2]Dependency and cleanup:
Meziantou.AnalyzerNuGet package version from 3.0.104 to 3.0.105.System.Diagnostics.CodeAnalysisusing directives from parser factory files. [1] [2]