Conversation
…r block id changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds versioned transformers, which allow mods to update chunk- and player-level data based on their own version stamping. This principally allows for transforming items who technically do not cease to exist, such as metadata shuffles within one item. The mod can stamp some metadata arrangement as V1, and some other arrangement as V2. Where postea encounters a chunk saved under V1, it provides it to the mod, which can then handle updating the arrangement. This sort of arrangement is one I plan to use within https://github.com/Ruling-0/MaterialLib to handle crossmod-integration and version changes without needing hard-coded metadata values for materials. This PR shows the system -- the full files can be explored from that branch if needed.
This PR also removes or corrects old/deprecated code and doc where it encounters it, especially a lot of older chunkapi detection that is obsolete.
Tested and confirmed that normal transformers (that I am using to remap GT materials to ML ones) continued to function with this integrated, which should be a sufficient stress test since it is remapping items/blocks/TEs.
Checklist