Enforce non-nullability of return values for transformation handlers - #21
Merged
Merged
Conversation
I was tempted to add this in the main refactor pr but choose not to for the sake of easier clarity but clearly it's more prone to causing errors down the line so better fix it now than never.
boubou19
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was tempted to add this to the main refactor PR, but chose not to for clarity. It's clearly more prone to errors down the line, so it's better fix it now than never.
The following mods will need dep updates to work properly, since the new interface isn't fully type-analogous (Pointer boolean -> primitive boolean can't be done at runtime).
Important
GT5u should be updated before the core mod since the core mod inherits postea via GT5u; WG technically does too, but it's also overriding the dep in its build file (could probably be removed).