Allow Panel and Screen Creation to Fail - #156
Open
Vlamonster wants to merge 2 commits into
Open
Conversation
4 tasks
Vlamonster
changed the title
Vlamonster
added
Bug Fix
brachy84
requested changes
Jul 30, 2026
brachy84
reviewed
Jul 30, 2026
| if (panel == null) throw new IllegalStateException("Panel must not be null on Client when Panel was not null on Server!"); | ||
| WidgetTree.collectSyncValues(syncManager, panel); | ||
| ModularScreen screen = factory.createScreen(guiData, panel); | ||
| if (screen == null) throw new IllegalStateException("Screen must not be null on Client when Screen was not null on Server!"); |
Collaborator
There was a problem hiding this comment.
Technically server doesnt have a screen. Its just the panel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
NotNulltoNullablecontract for creating panels and screens.Cancels opening GUI upon a null panel or screen.
Adaptation in gt5u: Adapt to MUI2 getGuiHolder Change- #7613.
Checklist