Fix Stylelint Errors#57
Conversation
- remove all linting errors from _all.scss through _global.scss - add "selector-type-no-unknown" stylelint rule for allowing custom tags such as "quality-tag" - add "no-descending-specificity" stylelint rule for ignoring ordering. I am currently following this rule but disabling due to not behaving correctly for nested pseudo classes (stylelint/stylelint#2489) Tried to group imports in _all.scss under sections according to order in the navigation. Let me know if you want different ordering (alphabetic?)
|
@vollmerr In CircleCI and locally, I'm still getting linting errors. Just verifying as this PR description had me thinking you worked to fix all of those. Is that right? |
|
Sorry I should have been more specific, I had only done about half the files (in alphabetic order) _all.scss through _global.scss, as you said you wanted it broken up to make it easier to review. There is still _hamburgers.scss through _variables.scss that have no changes currently and will have errors. Not really sure what the best way of doing this, but my plan was for doing the rest in another commit (or several if easier) in this PR, and it would (hopefully) not effect the files you had already approved. Do you want me to go ahead an do all files? As a side note, in _cards.scss I added in a section with linting disabled because the order of the properties matter. If it is after the background declaration it displays a rectangle. If the background-color is not needed (I assume its there for fallback in browsers that don't support data urls) it should be removed, otherwise I think it should be looked at for refactoring without using data urls in a different PR |
|
Gotcha! Breaking it up is awesome, thanks for clarifying. |
2 participants
This PR fixes issue #51, removing all linting errors.
In addition, it adds some stylelint rules to fix some errors: