Skip to content
This repository was archived by the owner on Aug 4, 2020. It is now read-only.

fix: text wrapping for 2-line filters#104

Merged
saracope merged 1 commit into
GSA:masterfrom
heatherdesigns:fix-issue-319
Nov 13, 2019
Merged

fix: text wrapping for 2-line filters#104
saracope merged 1 commit into
GSA:masterfrom
heatherdesigns:fix-issue-319

Conversation

@heatherdesigns

Copy link
Copy Markdown
Contributor

Resolves issue #319

Summary

This PR fixes a bug found in Chrome where when the content of a list item in the filter box wrapped onto another line, it was partially hidden by the checkbox.

Screenshot of issue

before

Test plan (required)

To test this PR locally, sync the code-gov-styles repo with the code-gov-front-end repo.
In code-gov-front-end run npm run start to start the server.
Open the Chrome web browser and go to http://localhost:8080/browse-projects?&page=1&size=10&sort=data_quality
Review the filter list styles and verify that list items which span more than one line of content flow to the right of the checkbox and not behind it.

** Screenshot of expected results**

after

Closing issues

Closes #319

@heatherdesigns

Copy link
Copy Markdown
Contributor Author

@saracope 👋 I did a thing. 😆
Although this does change the placement of the checkbox alongside the list item. It is centered vertically rather than beside the first line of content.

This is what it looks like in Safari before the change in this PR:

safari

Let me know if you would like to have the checkbox styles updated to match what is seen in Safari where it is aligned beside the first line of content.

@saracope

saracope commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

Awesome. I'll take a look at this. Thanks!

@saracope

Copy link
Copy Markdown
Contributor

This is great, thanks!

@saracope saracope merged commit 479a2d3 into GSA:master Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants