This repository was archived by the owner on Aug 4, 2020. It is now read-only.
fix: text wrapping for 2-line filters#104
Merged
Merged
Conversation
Resolves issue #319 GSA/code-gov-front-end#319
Contributor
Author
|
@saracope 👋 I did a thing. 😆 This is what it looks like in Safari before the change in this PR: Let me know if you would like to have the checkbox styles updated to match what is seen in Safari where it is aligned beside the first line of content. |
Contributor
|
Awesome. I'll take a look at this. Thanks! |
Contributor
|
This is great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves issue #319
Summary
This PR fixes a bug found in Chrome where when the content of a list item in the filter box wrapped onto another line, it was partially hidden by the checkbox.
Screenshot of issue
Test plan (required)
To test this PR locally, sync the
code-gov-stylesrepo with thecode-gov-front-endrepo.In
code-gov-front-endrunnpm run startto start the server.Open the Chrome web browser and go to http://localhost:8080/browse-projects?&page=1&size=10&sort=data_quality
Review the filter list styles and verify that list items which span more than one line of content flow to the right of the checkbox and not behind it.
** Screenshot of expected results**
Closing issues
Closes #319