Monkeypatch test output with signal description#89
Closed
McSinyx wants to merge 1 commit intoGJDuck:masterfrom
Closed
Monkeypatch test output with signal description#89McSinyx wants to merge 1 commit intoGJDuck:masterfrom
McSinyx wants to merge 1 commit intoGJDuck:masterfrom
Conversation
Termination signal descriptions like "Illegal instruction" are printed by the invoking shell, not the running process, thus cannot be captured via stream redirection. The more proper way to test for signals is probably saving them under a file like test/regtest/*.sig but it is less obvious what signal a number maps to when debugging.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Termination signal descriptions like "Illegal instruction" are printed by the invoking shell, not the running process, thus cannot be captured via stream redirection.
The more proper way to test for signals is probably saving them under a file like
test/regtest/*.sigbut it is less obvious what signal a number maps to when debugging.I fail to understand why
WIFEXITED(r)andWEXITSTATUS(r) - 128works but (the supposedly semantically more correct according to the manual pages)WIFEXITED(r)andWTERMSIG(r)does not though.