Skip to content

Import GH 5 features (WIP)#113

Merged
aoles merged 114 commits intoors_4.0from
chore/merge_gh_5
Apr 29, 2026
Merged

Import GH 5 features (WIP)#113
aoles merged 114 commits intoors_4.0from
chore/merge_gh_5

Conversation

@aoles
Copy link
Copy Markdown
Member

@aoles aoles commented Apr 7, 2026

The goal is to import individual GH 5 features as listed in release notes by merging them one-by-one an resolving possible conflicts,

git merge <commit>

where <commit> is the corresponding GH merge commit hash obtained from the list.

easbar and others added 30 commits September 29, 2021 12:49
* current tests pass

* minor clarifications

* fix test and heading for only one point is fine

* changed comment

* make test stable

* no need to check edge twice as it is the same segment for both directions; do not forget to check end pillar node in distance calc

* only calc heading of geometry first (graphhopper#2415)

* only calc heading of geometry first

* Fix test (?!)

* minor

* Flip heading edge filter condition

* move method and add comments

* minor

Co-authored-by: Andi <easbar.mail@posteo.net>
* Make sure GHDirectory#find only uses each name once

* Rename Directory#find -> Directory#create
Co-authored-by: Thomas Butz <thomas.butz@optitool.de>
* use jdk17 ga and jdk18 ea

* adoptopenjdk is adoptium and I cannot find ea versions, so use the default ones (sormuras/bach -> install-jdk.properties)

* since jdk17 locale IDs changed
Co-authored-by: Thomas Butz <thomas.butz@optitool.de>
@aoles aoles force-pushed the chore/merge_gh_5 branch from 8178c40 to 73e71e9 Compare April 16, 2026 22:42
@aoles aoles force-pushed the chore/merge_gh_5 branch from 81b0ebf to 95f4582 Compare April 21, 2026 20:28
@aoles aoles marked this pull request as ready for review April 29, 2026 10:45
Copy link
Copy Markdown

@sfendrich sfendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in pair programming.

@aoles aoles merged commit 090a8b4 into ors_4.0 Apr 29, 2026
1 of 2 checks passed
@aoles aoles deleted the chore/merge_gh_5 branch April 29, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants