feat: Python interfaces to geos from Makutu repo#44
Conversation
|
as a minor comment: change |
Bubusch
left a comment
There was a problem hiding this comment.
Thanks @av-novikov, looks good.
@sframba @Victor-M-Gomes maybe at some point we can move all pygeos-tools/utilities up under pygeos-tools/ and make the package a bit more flat. We might also have to set some constraints on dependencies versions when installing on ppc architecture.
|
@av-novikov Hello! I am currently working in the geos-mesh repository, which includes Python packages for pre-processing VTK grids, specifically through a tool called mesh_doctor. I've noticed that some of the features you are adding might overlap with existing functionalities in mesh_doctor. To avoid redundancy, I suggest we collaborate to identify and merge these features effectively. This way, we can enhance mesh_doctor without duplicating efforts across two repositories. I'm happy to assist with this process. @cssherman, what are your thoughts on this approach? |
fixed, thanks @untereiner !
Dear @alexbenedicto, thanks for looking inside! I can imagine that some of this functionality my overlap with existing and I am happy to contribute to the further development of the Python side of GEOS. However, this particular functionality is taken from Makutu-team repo as is. Thus, it is better to coordinate further its modification with Makutu developers, e.g. with @sframba. |
|
I am reverting this merge. The repository had no restrictions in place but PRs this large should not be merged with a single approving reviewer, especially considering that there was a comment by @alexbenedicto pointing out that he would have liked to discuss how to proceed considering the amount of duplicated capabilities. Please discuss with @alexbenedicto about how to proceed before remerging this. |
This PR merges some Python interfaces to GEOS from Makutu repository. These interfaces are coming as a part of GEOS: PR 3391 and required to simplify interactions with GEOS from Python.