Skip to content

Setup the geos python package CI#4

Merged
cssherman merged 7 commits into
mainfrom
feature/sherman/setupCI
Jan 18, 2024
Merged

Setup the geos python package CI#4
cssherman merged 7 commits into
mainfrom
feature/sherman/setupCI

Conversation

@cssherman
Copy link
Copy Markdown
Collaborator

No description provided.

@cssherman cssherman requested a review from TotoGaz January 12, 2024 01:04
@cssherman
Copy link
Copy Markdown
Collaborator Author

@TotoGaz - any thoughts on the CI configuration? I'm building off of the github template for python packages here. Do you want to add/remove any python versions? Also, I've commented out the linting and testing steps for now, as we haven't been enforcing these yet.

Comment thread .github/workflows/python-package.yml Outdated
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have python 3.8? I kind of remember there are some differences for type hints starting python 3.9.
Those differences were popping errors on ubuntu 20.04 (IIRC) but the differences are not worth ditching 3.8 from the supported platforms.


steps:
- uses: actions/checkout@v3
- uses: mpi4py/setup-mpi@v1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to rely on this or should we prefer installing from requirements.txt?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These help to setup the underlying python and mpi environments (needed for mpi4py to not throw an error). We could probably roll our own, but these actions seem to be quite reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants