fix(ios): keep QR capture work off main thread - #2853
Open
wgqqqqq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Scanning a pairing QR code could freeze the iOS UI because
AVCaptureSession.startRunning()andstopRunning()executed synchronously on the main thread. The scanner also let UIKit and SwiftUI dismiss the same cover independently.Changes
Validation
./Testing/run-pure-swift-tests.shgit diff --check upstream/main...HEADThe live device run verified the queue and dismissal fix. The final lazy-initialization refinement was then device-build verified after the log exposed a separate capture-session initialization stall.