fix(nav): prefer connection aliases in remote workspace badges - #2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A remote workspace badge showed the SSH address even when the saved connection had an alias, while dispatch displayed that alias. Use the existing connection label for the workspace badge and its accessible name: trimmed connection alias first, SSH address next, then connection ID. The tooltip retains the real SSH address and connection status.
Verification
pnpm run check:web— passed after preparing generated API types and design-system packages in the fresh worktree.pnpm --dir src/web-ui exec vitest run src/app/components/NavPanel/sections/workspaces/WorkspaceListSectionLayout.test.ts src/app/components/NavPanel/sections/sessions/SessionsSectionLayout.test.ts src/app/components/NavPanel/sections/workspaces/WorkspaceItemSessionBatchManagement.test.ts— 20 passed.git diff --check— passed.AI-assisted; focused automated verification completed. This is a frontend label change using existing workspace metadata. Live SSH/Peer Device Mode sessions and mobile remote control were not exercised in this PR; dispatch continues to use its target display name. No styles, persisted shapes, or transport behavior changed.
Please use a merge commit when merging this PR.