fix(web): unify session model and reasoning menus - #2834
Merged
Conversation
3 tasks
SWangHash
pushed a commit
to SWangHash/BitFun-OHOS
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dispatch and ACP sessions currently show a separate reasoning control beside the model picker, while native sessions place reasoning inside the model settings menu. All three now share the same first-level model/reasoning menu and flyouts, with the current reasoning level displayed inside the model trigger.
Type and Areas
Type: Bug fix / UI consistency
Areas: Shared desktop/Web UI conversation composer
Motivation / Impact
autowhen provided, rather than a local reset that ACP cannot apply.Verification
Rebased onto current upstream
mainand verified:pnpm --dir src/web-ui exec vitest run src/flow_chat/components/ModelSelectorExternal.test.tsx src/flow_chat/components/ModelSelectorProviderLevels.test.tsx src/flow_chat/components/ModelSelectorAcpMode.test.tsx src/flow_chat/components/ModelSelectorPortalLayer.test.ts src/flow_chat/components/ChatInputWorkspaceStripLayout.test.ts src/flow_chat/components/modelSelectorDropdownPosition.test.ts— 78 tests passed across 6 files.pnpm run check:web— passed, including type checking and appearance/theme gates.pnpm run motion:audit— passed (advisory inventory).node scripts/check-git-object-sizes.mjs --base upstream/main --head HEAD— passed.git diff --check— passed before commit.Reviewer Notes
AI-assisted (Codex); testing level: lightly tested with automated component and contract coverage, without manual visual verification. Remote workspace ACP parameters and detached dispatch callbacks were exercised through mocks. No live remote workspace, remote control, Peer Device, or detached dispatch end-to-end runs were performed. No persisted shapes, wire protocols, or backend ownership changed. No before/after recording was captured.
Checklist