feat: 대화 주제 추천 프롬프팅 작성 - #21
Conversation
|
Warning Review limit reached
More reviews will be available in 48 minutes and 33 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 Walkthrough개요뉴스레터 분석 응답에 대화주제 추천 기능을 추가하고, AWS 배포 워크플로우의 SSM 명령어 구성을 수정하는 변경입니다. 변경 사항대화주제 추천 기능
AWS SSM 배포 워크플로우
코드 리뷰 난이도🎯 2 (단순) | ⏱️ ~12분 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/schemas.py`:
- Around line 84-86: The ConversationTopic model's topic field lacks validation;
update the ConversationTopic class to enforce sensible constraints by adding a
Pydantic field validator or Field(...) metadata on topic (e.g., min_length and
max_length) and optionally a regex if needed, and include a clear validation
error message; modify the topic declaration in ConversationTopic to use
Field(..., min_length=1, max_length=200) or implement a `@validator`("topic")
method to trim/validate and raise ValueError for invalid values.
In `@app/services/newsletter_prompt.py`:
- Around line 60-67: CONVERSATION_TOPIC_SCHEMA's "topic" property lacks string
length constraints; add "minLength" and "maxLength" to the "topic" schema entry
so the JSON schema enforces the same bounds as the corresponding Pydantic model
(keep values aligned with the Pydantic model's limits), i.e., update the
CONVERSATION_TOPIC_SCHEMA -> properties -> "topic" to include minLength and
maxLength that match the model's validation.
- Around line 137-139: The exclusion rule "학부모가 이미 알고 있는 사실을 단순히 확인하는 질문은 제외한다"
is ambiguous—update the prompt text in newsletter_prompt.py to include 2–3
concrete examples (e.g., "오늘 학교에 갔나요?", "점심은 무엇을 먹었나요?", "숙제를 했나요?") and a brief
clarifier (e.g., "이미 보고된 사실을 재확인하는 질문은 제외"). Locate and modify the exact string
block containing that rule so the LLM sees the examples inline and returns
clearer, consistent behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 58219535-52c0-4422-8ba0-710eda01185a
📒 Files selected for processing (3)
.github/workflows/deploy-ai-ec2.ymlapp/schemas.pyapp/services/newsletter_prompt.py
deli-minju
left a comment
There was a problem hiding this comment.
가정통신문 분석 결과에서 학부모가 자녀와 자연스럽게 이야기할 수 있는 주제를 제공하도록 확장된 점이 서비스 흐름에 잘 맞는 것 같습니다. 행정성 내용과 개인정보 항목을 제외하도록 제한한 부분도 적절해 보입니다. 고생하셨습니다!
📌 작업 요약
🌿 브랜치 정보
feat/#20-conversation-recommenddevelop(기본)✅ 체크리스트
feat/refac/hotfix/chore/design/bugfix)feat/fix/refactor/docs/style/chore)🧪 테스트 결과
Summary by CodeRabbit
New Features
Chores