Repository navigation
Fix subscription count display on watch page with IV API - #8255
Merged
FreeTubeBot merged 2 commits intoNov 11, 2025
Merged
Conversation
PikachuEXE
requested review from
a user,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
November 10, 2025 05:37
github-actions
Bot
added
the
PR: waiting for review
FreeTubeBot
enabled auto-merge (squash)
November 10, 2025 05:37
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Nov 10, 2025
ghost
reviewed
Nov 10, 2025
| this.videoTitle = result.title | ||
| this.videoViewCount = result.viewCount | ||
| this.channelSubscriptionCountText = isNaN(result.subCountText) ? '' : result.subCountText | ||
| this.channelSubscriptionCountText = isNaN(result.subCountText.replace(/[KM]$/, '')) ? '' : result.subCountText |
There was a problem hiding this comment.
For better localization support, we should probably do the same thing we do for local api (parseLocalSubscriberCount and formatNumber)
FreeTube/src/renderer/views/Watch/Watch.js
Lines 500 to 506 in c687a1c
Member
Author
|
Updated & tested |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 11, 2025
ghost
approved these changes
Nov 11, 2025
absidue
approved these changes
Nov 11, 2025
github-actions
Bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 18, 2025
* development: Fix playlist video view counts on the local API (FreeTubeApp#8290) change hardcoded color app text logoColor (FreeTubeApp#8288) Translated using Weblate (Russian) Translated using Weblate (German) wrap long playlist strings (FreeTubeApp#8275) Translated using Weblate (Bulgarian) Bump js-yaml from 4.1.0 to 4.1.1 (FreeTubeApp#8284) bump workflows node-version to 24 (FreeTubeApp#8279) Translated using Weblate (Basque) Translated using Weblate (Vietnamese) Translated using Weblate (Hungarian) Translated using Weblate (Hungarian) Remove upperCase on various places (FreeTubeApp#8267) Translated using Weblate (French) Fix subscription count display on watch page with IV API (FreeTubeApp#8255) Specify window position in constructor for better wayland compatibility (FreeTubeApp#8238) Change profile icon to include lowercase letters (FreeTubeApp#8253) Translated using Weblate (German) Translated using Weblate (Chinese (Traditional Han script)) Translated using Weblate (Portuguese (Brazil))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
#8245 (comment)
Description
Subscription count text with suffix
K/Mnot handled properly and thus hiddenThis PR fixes it
Screenshots
Lazy
Testing
Ksuffix handled (e.g. https://youtu.be/3K8HqmQWmW4Msuffix handled (e.g. https://youtu.be/fFtk9gJLnfkDesktop
Additional context