Improve mailsync wrapper script environment variable handling#105
Merged
Improve mailsync wrapper script environment variable handling#105
Conversation
Replace the child-process invocation of mailsync.bin with exec so bash replaces itself with the binary. This ensures SIGTERM is delivered directly to mailsync.bin rather than to the wrapper shell, providing defense-in-depth for clean process termination. Also export SASL_PATH and LD_LIBRARY_PATH explicitly for clarity. https://claude.ai/code/session_01TEFo1y7kgfu5D4vfRWhakY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the mailsync wrapper script generation in the Linux build process to properly export environment variables and use
execfor cleaner process management.Key Changes
SASL_PATHandLD_LIBRARY_PATHassignments to useexportstatements, ensuring they are properly propagated to the mailsync.bin processexportdeclarations for better clarity and reliabilityexecbefore the mailsync.bin invocation to replace the shell process, improving process hierarchy and signal handlingImplementation Details
These changes ensure that:
exec), which is important for proper signal handling and process managementhttps://claude.ai/code/session_01TEFo1y7kgfu5D4vfRWhakY