[timlichtenberg]

Description

codecov/project failed on #952 and #953 although both raised coverage in each flag (unit tests 92.14 to 92.15 and 92.16 %, nightly 95.45 to 95.52 and 95.53 %) and neither touched the lines it reported. On a main commit whose nightly session is carried forward, the combined Codecov report is not the union of its two flag reports: on a2c5c17, eight branch statements in interior_energetics count as hit or partial in the combined report and as missed in both the unit-tests and the nightly view. A PR head with real uploads then reads lower. Once main gets its own nightly upload the combined report agrees with the flags again (26f73aa: 11 mismatched lines before its nightly upload, 0 after).

This PR compares project coverage per flag, so each flag compares like with like:

• codecov/project keeps its name and reads the unit-tests flag.
• codecov/project/nightly is new and reads the nightly flag. Until the branch nightly has run, the head carries the nightly data of the base as it was at the head's first upload, so it can differ from the base if main got a newer nightly in between; the branch nightly settles it.
• codecov/patch is unchanged and still reads all flags. Targets are unchanged.

A PR whose new code only the smoke or slow tiers cover now shows a lower codecov/project; codecov/project/nightly shows that code once the branch nightly has run.

Validation of changes

• codecov.yml passes codecov.io/validate.
• A docs-only branch on top of this one (4e15d01): codecov/project 92.15 % (+0.00 %), codecov/project/nightly 95.44 % (+0.00 %) without a branch nightly, and 95.53 % (+0.08 %) after it. The combined total on that branch fell from 95.56 to 95.53 %, which is the case that failed Require fwl-aragog 26.10.03 #952.
• Per flag, Fix the mass and volatile bookkeeping of impacts and escape #950 to Keep the escape floor off a frozen mantle and book desiccation #953 would all have passed.
• On this PR: codecov/project 92.16 % (+0.00 %); codecov/project/nightly read 95.44 % (-0.09 %) before the branch nightly, because the head's first upload came before main's own nightly, and 95.53 % (+0.00 %) after it.

Checklist

• I have followed the contributing guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my code
• My changes generate no new warnings or errors
• I have checked that the tests still pass on my computer
• I have updated the docs, as appropriate
• I have added tests for these changes, as appropriate
• I have checked that all dependencies have been updated, as required

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.54%. Comparing base (26f73aa) to head (7b99084).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #954   +/-   ##
=======================================
  Coverage   95.53%   95.54%           
=======================================
  Files         127      127           
  Lines       21160    21160           
  Branches     3595     3595           
=======================================
+ Hits        20216    20217    +1     
+ Misses        944      943    -1     

Flag	Coverage Δ
nightly	95.53% <ø> (ø)
unit-tests	92.16% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.