Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Can this be approved/merged? I'm also encountering this issue and would like to not have to override the react-live types. |
Merged
Contributor
|
Thank you for the contribution. I moved it over to this project's new directory structure and added a changeset. #356 |
Contributor
|
Released as part of 4.1.0, once again thanks! https://github.com/FormidableLabs/react-live/releases/tag/react-live%404.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LivePreviewforwards all props to the renderedComponent, but the current types doesn't allow you to do so because they aren't explicitly defined in thePropstype. In my code, it was showing an error when I was trying to passclassNameintoLivePreview.This PR changes the types so that the rest of the props can be inferred from what type of component is used.
I also removed
fallbackComponentbecause you can do the same thing by using a default param of"div"