Skip to content

On-Call Roster Inorrectly Identifies Public/Regional Holidays in Australia #177

Open

Description

@notscottsmith

Version

v1.1.0

Installation method

Docker Compose

Describe the bug

The holidays are imported successfully, but since Australia has different public holidays in different states, it's showing all public holidays whether they're relevant to the timezone configured or not.

If holidays are going to be imported, we should be able to either edit them for accuracy, allow for the manual creation of public holidays or supply an API which can retrieve the data required for populate the schedule_holidays table.

Image

In WA, daylight savings isn't a thing and the regional holiday marker next to it is for ACT, SA and NSW only and Queensland has a public holiday but it's for a different reason than what's named (which isn't in the table). Western Australia's is the week before (which is there correctly).

The limitation of just country code in the schedule_holidays table is going to make using this difficult for teams which spread across the country for monitoring with different rosters (unless editing is made possible).

Image

You may need to add "jurisdiction" (so you include states, territories, regions, etc) as a nullable field for any nationwide holidays and have it filled for state/region specific ones.

Steps to reproduce

  1. Create Roster
  2. Set Timezone
  3. Wait for public holidays to be imported

Expected behavior

No response

Relevant logs or screenshots

Area

On-call scheduling

Activity

  1. singret commented on Oct 18, 2026

    @singret
    Contributor

    Thanks for the clear write-up. You're right about the cause. We import one feed per country, and Australia's feed mixes every state's holidays (and some non-holidays, like "Daylight Saving Time starts"), so a Perth schedule shows days that don't apply to it. Using the timezone to guess the state wouldn't be reliable either.

    A first fix is up in #180. Admins get a Holidays panel on the schedule page where they can hide holidays that don't apply, rename them, and add their own. The daily sync keeps running but won't undo your changes: hidden stays hidden, and renamed or added holidays are left alone. It will be in the next release.

    That doesn't fix the data itself. Holidays still aren't tied to a state or region, so a team has to curate its own list. Your jurisdiction suggestion is the right long-term fix. I'm leaving this issue open for that. I'll comment here when #180 ships.

  2. singret commented on Oct 18, 2026

    @singret
    Contributor

    Admin holiday editing is out in v1.2.0. Admins can hide, rename and add holidays from the Holidays panel on the schedule page, and the daily sync won't undo those changes. The upgrade runs one new migration automatically.

    I'm leaving this issue open for the longer-term fix: tying holidays to a state or region so teams don't have to curate the list themselves.

  3. notscottsmith commented on Oct 19, 2026

    @notscottsmith
    Author

    Excellent work, I look forward to testing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions