Fix dashboard deploy#96
Conversation
📝 WalkthroughWalkthroughThis PR replaces inline Bash artifact-download logic in the CI workflow with a new Node.js script that uses the GitHub REST API to discover and fetch the latest Picofuzz CSV artifacts for all configured teams. The workflow now invokes the script with repository context via the ChangesArtifact Download Migration
🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/deploy-dashboard.yml (1)
3-6:⚠️ Potential issue | 🟠 MajorFix
deploy-dashboard.ymlto includeworkflow_run.workflowsentries for all team performance workflows
.github/workflows/deploy-dashboard.ymlcurrently triggers only viascheduleandworkflow_dispatch(lines 3-6); there is noworkflow_runtrigger.- The repo has many
*-performance.ymlworkflows for teams underteams/, but a repository-wide search findsNo workflow_run triggers found in any workflow, so the requiredworkflow_run.workflowslist entries are missing.Current trigger block in `deploy-dashboard.yml`
on: schedule: - cron: '0 8,20 * * *' workflow_dispatch:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/deploy-dashboard.yml around lines 3 - 6, The deploy-dashboard.yml currently only defines the "on" triggers "schedule" and "workflow_dispatch"; add a "workflow_run" trigger with a "workflows" list including every team performance workflow filename (the repo's "*-performance.yml" workflows under teams/) and appropriate "types: [completed]" so the dashboard run is invoked after those team performance workflows finish; update the "on" block to include "workflow_run.workflows" entries and ensure you keep the existing "schedule" and "workflow_dispatch" keys.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/deploy-dashboard.yml:
- Around line 3-6: The deploy-dashboard.yml currently only defines the "on"
triggers "schedule" and "workflow_dispatch"; add a "workflow_run" trigger with a
"workflows" list including every team performance workflow filename (the repo's
"*-performance.yml" workflows under teams/) and appropriate "types: [completed]"
so the dashboard run is invoked after those team performance workflows finish;
update the "on" block to include "workflow_run.workflows" entries and ensure you
keep the existing "schedule" and "workflow_dispatch" keys.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3f3c245e-022d-4e5f-bfc7-d475ee2e479b
📒 Files selected for processing (2)
.github/workflows/deploy-dashboard.ymlscripts/download-latest-picofuzz-artifacts.cjs
Summary by CodeRabbit
New Features
Refactor