Skip to content
This repository was archived by the owner on Jun 7, 2026. It is now read-only.

Fix dashboard deploy#96

Merged
tomusdrw merged 1 commit into
mainfrom
td-fix-dashboard-deploy
May 28, 2026
Merged

Fix dashboard deploy#96
tomusdrw merged 1 commit into
mainfrom
td-fix-dashboard-deploy

Conversation

@tomusdrw

@tomusdrw tomusdrw commented May 27, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added automated Picofuzz CSV artifact download capability for all teams.
  • Refactor

    • Simplified deployment workflow by centralizing artifact download logic into a dedicated script, improving maintainability and reducing inline workflow complexity.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR replaces inline Bash artifact-download logic in the CI workflow with a new Node.js script that uses the GitHub REST API to discover and fetch the latest Picofuzz CSV artifacts for all configured teams. The workflow now invokes the script with repository context via the GITHUB_REPOSITORY environment variable.

Changes

Artifact Download Migration

Layer / File(s) Summary
Artifact discovery via GitHub API
scripts/download-latest-picofuzz-artifacts.cjs
CLI setup, environment validation, GitHub REST API client with bearer token auth and rate-limit awareness, team name enumeration, and paginated artifact list scanning to select the newest non-expired artifact per team/benchmark combination.
Artifact download and extraction
scripts/download-latest-picofuzz-artifacts.cjs
Downloads artifact ZIP files via their API download URLs, unzips contents into output directories, and guarantees cleanup of temporary files via finally block.
Script orchestration and error handling
scripts/download-latest-picofuzz-artifacts.cjs
Main entry point validates arguments and environment, orchestrates discovery and download in deterministic order, enumerates and logs extracted CSV file paths, and handles top-level errors with stack traces.
Workflow integration
.github/workflows/deploy-dashboard.yml
Updates the artifact download step to invoke the Node.js script instead of Bash, passing GITHUB_REPOSITORY environment variable for repository context.

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly Related PRs

  • FluffyLabs/jam-testing#66: Also modified the "Download latest picofuzz artifacts" step in .github/workflows/deploy-dashboard.yml, adding 3-attempt retries and stricter filtering to the prior gh run download approach before this PR replaced it entirely with the Node.js implementation.

Poem

🐰 From bash to Node, the artifacts now flow,
Through REST API pages, the latest ones glow,
Teams and benchmarks in harmony blend,
CSV paths logged, the workflow's new friend!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Fix dashboard deploy' is vague and generic, using broad language that doesn't convey the specific nature of the change (refactoring artifact download logic into a dedicated Node.js script). Consider a more descriptive title such as 'Extract picofuzz artifact download logic into dedicated script' or 'Refactor dashboard deploy artifact handling' to clarify the primary change.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch td-fix-dashboard-deploy

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/deploy-dashboard.yml (1)

3-6: ⚠️ Potential issue | 🟠 Major

Fix deploy-dashboard.yml to include workflow_run.workflows entries for all team performance workflows

  • .github/workflows/deploy-dashboard.yml currently triggers only via schedule and workflow_dispatch (lines 3-6); there is no workflow_run trigger.
  • The repo has many *-performance.yml workflows for teams under teams/, but a repository-wide search finds No workflow_run triggers found in any workflow, so the required workflow_run.workflows list entries are missing.
Current trigger block in `deploy-dashboard.yml`
on:
  schedule:
    - cron: '0 8,20 * * *'
  workflow_dispatch:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/deploy-dashboard.yml around lines 3 - 6, The
deploy-dashboard.yml currently only defines the "on" triggers "schedule" and
"workflow_dispatch"; add a "workflow_run" trigger with a "workflows" list
including every team performance workflow filename (the repo's
"*-performance.yml" workflows under teams/) and appropriate "types: [completed]"
so the dashboard run is invoked after those team performance workflows finish;
update the "on" block to include "workflow_run.workflows" entries and ensure you
keep the existing "schedule" and "workflow_dispatch" keys.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/deploy-dashboard.yml:
- Around line 3-6: The deploy-dashboard.yml currently only defines the "on"
triggers "schedule" and "workflow_dispatch"; add a "workflow_run" trigger with a
"workflows" list including every team performance workflow filename (the repo's
"*-performance.yml" workflows under teams/) and appropriate "types: [completed]"
so the dashboard run is invoked after those team performance workflows finish;
update the "on" block to include "workflow_run.workflows" entries and ensure you
keep the existing "schedule" and "workflow_dispatch" keys.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3f3c245e-022d-4e5f-bfc7-d475ee2e479b

📥 Commits

Reviewing files that changed from the base of the PR and between 752ae03 and 18d993e.

📒 Files selected for processing (2)
  • .github/workflows/deploy-dashboard.yml
  • scripts/download-latest-picofuzz-artifacts.cjs

@tomusdrw tomusdrw merged commit dd76dc6 into main May 28, 2026
19 checks passed
@tomusdrw tomusdrw deleted the td-fix-dashboard-deploy branch May 28, 2026 04:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant