Open
Conversation
fumiama
requested changes
Feb 27, 2026
Member
fumiama
left a comment
fumiama
left a comment
There was a problem hiding this comment.
为什么不用github自己的registry呢，又不用自己加secret，构建上传都很方便，fork之后不用任何修改即可上传到自己的命名空间。
| - name: Login to DockerHub | ||
| uses: docker/login-action@v2 | ||
| with: | ||
| username: ${{ secrets.DOCKERHUB_USERNAME }} |
| rev.Stdout = &revOut | ||
| if rev.Run() == nil { | ||
| tag = strings.TrimSpace(revOut.String()) | ||
| } else { |
Member
There was a problem hiding this comment.
这个和下面的else冗余了，直接在最后判断一次tag==""即可
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.