Repository navigation
fix: avoid unnecessary single-channel reloads - #15
Open
mkrieger95 wants to merge 1 commit into
Open
mkrieger95 wants to merge 1 commit into
mkrieger95 wants to merge 1 commit into
Conversation
Only mark the memory card for reload when the selected channel actually changes. With MaxChannels=1, next/previous channel requests wrap back to the same channel, so reloading the card is unnecessary. Multi-channel behavior is unchanged because a successful channel switch still sets needs_update. Fixes FlipperMCE#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only mark the memory card for reload when the selected channel actually changes.
With MaxChannels=1, next/previous channel requests wrap back to the same channel, so reloading the card is unnecessary.
Multi-channel behavior is unchanged because a successful channel switch still sets needs_update.
Fixes #13