Skip to content

chore(deps-dev): bump @types/node from 24.2.0 to 26.0.1 - #1451

Closed
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/types/node-26.0.1
Closed

chore(deps-dev): bump @types/node from 24.2.0 to 26.0.1#1451
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/types/node-26.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 27, 2026

Copy link
Copy Markdown
Contributor

Bumps @types/node from 24.2.0 to 26.0.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 24.2.0 to 26.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.0.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 27, 2026
@dependabot
dependabot Bot requested a review from TabishB as a code owner July 27, 2026 01:46
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 27, 2026
@clay-good
clay-good requested a review from a team as a code owner July 27, 2026 17:31

@alfred-openspec alfred-openspec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenSpec still supports Node 20.19, so compiling against Node 26 types can admit APIs unavailable at the runtime floor even though the current suite passes. Please keep @types/node aligned with the supported runtime baseline; the Nix dependency hash is also currently red.

@clay-good

Copy link
Copy Markdown
Collaborator

Code review — verdict: merge once the Nix hash is updated

@types/node 24.2.0 → 26.0.1, a devDependency. Type-only, so it cannot affect shipped runtime behaviour — it can only cause compile errors, and it doesn't.

Verified

  • pnpm install --frozen-lockfile + npm run build: clean, no type errors.
  • Full suite: 112 files / 2253 tests, all passing, matching the origin/main baseline.
  • Lint & Type Check is green in CI.

Assessment

  1. Need: routine maintenance.
  2. Works: yes.
  3. Breaking: none. @types/node ships no runtime code and isn't in dependencies, so nothing reaches users' installs. Skipping two majors (24 → 26) would normally warrant caution about newly-strict or removed type definitions, but the build is clean against the real source tree, which is the check that matters.
  4. Scope: package.json + lockfile only.

Worth noting the two majors track Node 25/26 type surfaces while OpenSpec targets node >=20.19.0. That's normal and safe — @types/node remains backward-compatible for older runtimes — but it does mean the types can now describe APIs that don't exist on Node 20. The compiler won't catch a Node-20-absent API used from source. That's an argument for keeping the CI test matrix honest about the minimum supported Node version, not against this bump.

The shared blocker: flake.nix pnpmDeps hash

Nix Flake Validation is red:

error: hash mismatch in fixed-output derivation ...openspec-pnpm-deps.drv
    specified: sha256-82sVXXqj4mfe6n6BRagUiOQS0Gd+jbPOQiYzUhmrZGU=
       got:    sha256-rNUXCeNPuGKYB8TfhEv95dO1iTgyfKdnD5OXtFoMIYE=

Expected, and not the PR's fault: flake.nix pins a content hash of the pnpm dependency set, so any pnpm-lock.yaml change invalidates it and dependabot cannot update Nix files. One-line fix in flake.nix using the hash CI already computed above (or bash scripts/update-flake.sh locally with Nix installed).

One process note for the batch

Four lockfile-touching dependabot PRs are currently in this same state (#1448, #1451, #1452, #1453). Merging any one invalidates the hash on the other three, so serial merges mean four rounds of hash regeneration. Consolidating into a single PR with one lockfile resolution and one hash (as in #1427) would be much less churn. Leave #1450 out — it has a real API break needing a code change.

@clay-good

Copy link
Copy Markdown
Collaborator

Superseded by #1457, which consolidates this with the other three lockfile bumps into a single resolution.

Why consolidate: every one of these PRs changes pnpm-lock.yaml, and flake.nix pins a content hash of the pnpm dependency set — so merging them one at a time would invalidate that hash four times over, needing four regenerations and three rebases. Dependabot can't update Nix files, which is why all four were red on Nix Flake Validation. Same approach as #1427.

This PR's bump is carried over unchanged in #1457, which is green on all 15 checks including Nix Flake Validation and the full linux/macOS/Windows test matrix.

Worth noting for the record: the consolidated lockfile resolves to sha256-x3AFjyWjl2DkQFOnSuv8a90/JrZZpiweueORWaPxAbU=, which is different from the hash any of these PRs would have produced individually — so the per-PR hashes couldn't simply be reused.

@clay-good clay-good closed this Jul 27, 2026
@dependabot @github

dependabot Bot commented on behalf of github Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/types/node-26.0.1 branch July 27, 2026 19:08
pull Bot pushed a commit to edisplay/OpenSpec that referenced this pull request Jul 27, 2026
…sion-AI#1457)

* chore(deps): consolidate dependabot bumps (typescript 6, @types/node 26, ora 9, commander, posthog-node)

Replaces Fission-AI#1448, Fission-AI#1451, Fission-AI#1452 and Fission-AI#1453 with a single lockfile resolution.
Each of those PRs changed pnpm-lock.yaml, so merging them serially would
invalidate the flake.nix pnpmDeps hash four times over.

- typescript 5.9.3 -> 6.0.3 (Fission-AI#1452)
- @types/node 24.2.0 -> 26.x (Fission-AI#1451)
- ora 8.2.0 -> 9.4.1 (Fission-AI#1453)
- commander 14.0.0 -> 14.0.3, posthog-node 5.46.0 -> 5.46.1 (Fission-AI#1448, lockfile only)

Fission-AI#1450 (@inquirer/prompts 8) is deliberately excluded: it needs a code
migration, not a version bump.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore(nix): update pnpmDeps hash for bumped lockfile

Hash taken from this PR's first Nix Flake Validation run. Note it differs
from the hash any individual dependabot PR would have produced -- the
combined lockfile resolves to its own content hash.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore(deps): align @types/node with the Node 20.19 runtime floor

Addresses review feedback: compiling against Node 26 declarations lets the
type checker admit APIs that are unavailable on the runtimes OpenSpec
actually supports (engines: node >=20.19.0).

Pins @types/node to ^20.19.43, the latest release in the line matching the
declared floor. This also corrects a pre-existing drift -- main was on
@types/node 24 against the same 20.19 floor, so the types were already
ahead of the supported runtime before this PR.

Verified: build clean, tsc --noEmit clean, eslint clean, 112 files /
2253 tests passing, dist/ emit byte-identical to origin/main, and no peer
dependency warnings.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore(nix): update pnpmDeps hash for the realigned lockfile

The @types/node downgrade to the 20.19 line changed the dependency set
again (it pulls undici-types 6.21.0), so the previous hash no longer
matches. Value taken from a forced-mismatch Nix run on this branch.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants