chore(deps-dev): bump @types/node from 24.2.0 to 26.0.1 - #1451
chore(deps-dev): bump @types/node from 24.2.0 to 26.0.1#1451dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 24.2.0 to 26.0.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
alfred-openspec
left a comment
There was a problem hiding this comment.
OpenSpec still supports Node 20.19, so compiling against Node 26 types can admit APIs unavailable at the runtime floor even though the current suite passes. Please keep @types/node aligned with the supported runtime baseline; the Nix dependency hash is also currently red.
Code review — verdict: merge once the Nix hash is updated
Verified
Assessment
Worth noting the two majors track Node 25/26 type surfaces while OpenSpec targets The shared blocker:
|
|
Superseded by #1457, which consolidates this with the other three lockfile bumps into a single resolution. Why consolidate: every one of these PRs changes This PR's bump is carried over unchanged in #1457, which is green on all 15 checks including Worth noting for the record: the consolidated lockfile resolves to |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
…sion-AI#1457) * chore(deps): consolidate dependabot bumps (typescript 6, @types/node 26, ora 9, commander, posthog-node) Replaces Fission-AI#1448, Fission-AI#1451, Fission-AI#1452 and Fission-AI#1453 with a single lockfile resolution. Each of those PRs changed pnpm-lock.yaml, so merging them serially would invalidate the flake.nix pnpmDeps hash four times over. - typescript 5.9.3 -> 6.0.3 (Fission-AI#1452) - @types/node 24.2.0 -> 26.x (Fission-AI#1451) - ora 8.2.0 -> 9.4.1 (Fission-AI#1453) - commander 14.0.0 -> 14.0.3, posthog-node 5.46.0 -> 5.46.1 (Fission-AI#1448, lockfile only) Fission-AI#1450 (@inquirer/prompts 8) is deliberately excluded: it needs a code migration, not a version bump. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(nix): update pnpmDeps hash for bumped lockfile Hash taken from this PR's first Nix Flake Validation run. Note it differs from the hash any individual dependabot PR would have produced -- the combined lockfile resolves to its own content hash. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(deps): align @types/node with the Node 20.19 runtime floor Addresses review feedback: compiling against Node 26 declarations lets the type checker admit APIs that are unavailable on the runtimes OpenSpec actually supports (engines: node >=20.19.0). Pins @types/node to ^20.19.43, the latest release in the line matching the declared floor. This also corrects a pre-existing drift -- main was on @types/node 24 against the same 20.19 floor, so the types were already ahead of the supported runtime before this PR. Verified: build clean, tsc --noEmit clean, eslint clean, 112 files / 2253 tests passing, dist/ emit byte-identical to origin/main, and no peer dependency warnings. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(nix): update pnpmDeps hash for the realigned lockfile The @types/node downgrade to the 20.19 line changed the dependency set again (it pulls undici-types 6.21.0), so the previous hash no longer matches. Value taken from a forced-mismatch Nix run on this branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Bumps @types/node from 24.2.0 to 26.0.1.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)