Repository navigation
Fly the Bot mark between details and a side chat - #806
Merged
Merged
Conversation
Only the browser view was handled when the Bot panel flew the mark between the drawer avatar and the strip tab. Leaving details for a side chat picked the wrong source and found no target, so the drawer's large mark only faded out in the ghost copy for a frame. A side chat now flies the mark like the browser does, and the ghost no longer shows the mark a second time.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching side chat → Bot → side chat flashed the large mark for a frame.
Cause: the mark's flight between the drawer avatar and the strip tab only handled the browser view. Going from details to a side chat picked the strip mark as source and found no target, so nothing flew and the drawer's large mark only faded in the ghost copy.
Verified: unit tests, lint, leak scan. Not yet checked by eye in the desktop app.