Bump Microsoft.OpenApi.Kiota.Builder to 1.29.1 - #1160
Merged
Conversation
Fixes the codegen bug from microsoft/kiota#8038, now released as Microsoft.OpenApi.Kiota.Builder 1.29.1 (Microsoft.OpenApi 2.12.0). Verified via `Tests/IntegrationTests/FastEndpoints.OpenApi.Kiota` (client generation + command-mode export), which is otherwise excluded from CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gczAbMsgW4deQYkFpxdTZ
Member
|
legend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.OpenApi.Kiota.Builderfrom 1.29.0 to 1.29.1, addressing FastEndpoints.ClientGen.Kiota dependency has CVE (Microsoft.OpenApi.Kiota.Builder < v1.32.5) #1101.Microsoft.OpenApi/Microsoft.OpenApi.YamlReaderto 2.12.0 — all while staying on theMicrosoft.OpenApi2.x line so it doesn't conflict withMicrosoft.AspNetCore.OpenApi(still pinned to 2.x here).x-ms-enumdescription injection (GHSA-7f3j-j7jj-r3vr), Ruby#-interpolation injection (GHSA-xg2h-5xr2-29jw), C# doc-comment newline breakout (GHSA-3hrf-2gc2-mx32), PHP$-interpolation injection (GHSA-jqwh-526h-c92j), unsanitized client class/namespace names (GHSA-4vv7-jj25-4gh6), workspace output-path poisoning (GHSA-4rj6-vrwv-wr8m), plugin manifeststatic_template.filepath escape (GHSA-4jwf-m4wg-8p66), SSRF via unrestricted external$refresolution — now opt-in via--allowed-external-origins(GHSA-rg4h-fpcp-2qm8 / CVE-2026-59867), plus theMicrosoft.OpenApi2.12.0 bump (GHSA-v5pm-xwqc-g5wc) and an OpenTelemetry bump (GHSA-4625-4j76-fww9, GHSA-mr8r-92fq-pj8p, GHSA-q834-8qmm-v933).>= 1.32.5, but every Kiota.Builder release from 1.30.0 onward moved toMicrosoft.OpenApi3.x, which breaksMicrosoft.AspNetCore.OpenApi's XML-comment source generator on this repo's net10 target (confirmed locally:IOpenApiMediaType.Example cannot be assigned to -- it is read only). UntilMicrosoft.AspNetCore.OpenApiitself moves to OpenApi 3.x, 1.29.1 is the newest compatible version and closes 11 of the CVEs flagged by FastEndpoints.ClientGen.Kiota dependency has CVE (Microsoft.OpenApi.Kiota.Builder < v1.32.5) #1101 without a breaking change.dotnet restore/NuGet audit will still surfaceNU1903/NU1904warnings for 1.29.1 — the GHSA advisory version ranges haven't been narrowed to exclude this out-of-band 1.29.x backport yet, so the warnings are stale/expected, not unfixed vulnerabilities (see the kiota PR discussion).Test plan
dotnet build FastEndpoints.slnx -c Release— 0 errorsdotnet test Tests/IntegrationTests/FastEndpoints.OpenApi.Kiota/Int.OpenApi.Kiota.csproj -c Release— 4/4 passing (client-gen + command-mode export against the new builder; excluded from CI but run locally)dotnet test FastEndpoints.slnx -c Release --filter "ExcludeInCiCd!=Yes"— same 4 pre-existing snapshot/CRLF failures as onmain(verified unaffected by this change), no new failures🤖 Generated with Claude Code
https://claude.ai/code/session_016gczAbMsgW4deQYkFpxdTZ