pattern overlays#879
Merged
Merged
Conversation
…o use the render hook
Alwinfy
reviewed
Jul 14, 2025
|
|
||
| import java.util.function.Function; | ||
|
|
||
| public record HexPatternOverlayRenderer(Function<ItemStack, HexPattern> patternRetriever) implements ItemOverlayRenderer { |
Collaborator
There was a problem hiding this comment.
nit: why is this a record holding a FI and not just a FI itself? i.e.
@FunctionalInterface
public interface HexPatternOverlayRenderer extends ItemOverlayRenderer {
HexPattern getPattern(ItemStack stack);
}
Member
Author
There was a problem hiding this comment.
Don't remember, prob just didn't think of it. Want me to change it ?
object-Object
force-pushed
the
main
branch
4 times, most recently
from
107cf95 to
7202ed7
Compare
Robotgiggle
approved these changes
May 9, 2026
Member
Robotgiggle
left a comment
Robotgiggle
left a comment
There was a problem hiding this comment.
Made the change Alwinfy suggested - LGTM
Robotgiggle
force-pushed
the
pattern-overlays
branch
from
22f428a to
027188b
Compare
Robotgiggle
force-pushed
the
pattern-overlays
branch
from
48c1891 to
5dfb1f2
Compare
Robotgiggle
force-pushed
the
pattern-overlays
branch
from
5dfb1f2 to
321e54c
Compare
ChuijkYahus
pushed a commit
to ChuijkYahus/HexMod
that referenced
this pull request
May 28, 2026
…s#1043) The current implementation of the pattern overlay feature added in FallingColors#879 relies on a method in Inline that was renamed in the 1.2.0 update. Thus, if anyone uses a version of Inline beyond that point with the current version of hex, it will break. This PR updates hex's Inline dependency to the latest version and updates the relevant methods to their new names to prevent that from happening, and also updates a bunch of core libraries which are required for the new Inline version. Note that if this PR does _not_ get merged before the 0.11.4 release, we should instead change the Inline dependency in `fabric.mod.json` (fabric) and `mods.toml` (forge) to explicitly exclude Inline versions 1.2.0 and onwards. Also note that the new Kotlin version (2.2.21) now gives a bunch of warnings about the use of public `copy()` methods on data classes with private constructors, since that functionality will be removed in future versions of Kotlin. More info can be found [here](https://kotlinlang.org/api/core/kotlin-stdlib/kotlin/-consistent-copy-visibility/) and [here](https://kotlinlang.org/api/core/kotlin-stdlib/kotlin/-exposed-copy-visibility/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it does this when you shift. tested on forge and fabric, most of the work is done by inline's render hook. updated inline to be able to use it.