Advanced parenthesis patterns (and they're Actions now)#1103
Open
Robotgiggle wants to merge 5 commits into
Open
Advanced parenthesis patterns (and they're Actions now)#1103Robotgiggle wants to merge 5 commits into
Robotgiggle wants to merge 5 commits into
Conversation
Member
Author
|
FYI, I'm not entirely satisfied with the patterns for Meditation and Recollection - they're kind of awkward to fit into the grid when you have a bunch of other stuff. Recommendations would be appreciated, though make sure to avoid conflicting with stuff like Open/Close Transmit from Hexal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Interjection, Meditation, and Recollection to allow more advanced pattern-list building.
Meditation is treated as a normal pattern when inside existing parentheses because there's no way to determine how many new layers it should open. This is kind of a janky solution, but the only alternative would be to prevent using it inside parens altogether.
Recollection pushes the list on top of the depth for convenience, since you're much more likely to need the list as an argument for something (saving it to a focus, adding something with Integration Distillation, etc) than the number.