Skip to content

fix(build): emit package declarations with a blocking tsc pass #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FSM1 wants to merge 2 commits into from
Closed

fix(build): emit package declarations with a blocking tsc pass #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72d8c3f
fix(build): emit package declarations with a blocking tsc pass
FSM1 Jun 16, 2026
025bdef
chore(release): set release targets for PR #503
github-actions[bot] Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/api-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"scripts": {
"dev": "tsup --watch",
"build": "tsup",
"build": "tsup && tsc -p tsconfig.build.json",
"generate": "orval",
"lint": "eslint src/**/*.ts",
"test": "vitest run",
Expand Down
14 changes: 14 additions & 0 deletions packages/api-client/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"emitDeclarationOnly": true
},
"exclude": [
"node_modules",
"dist",
"src/**/*.test.ts",
"src/**/*.test.tsx",
"src/**/*.spec.ts",
"src/**/*.spec.tsx"
]
}
2 changes: 1 addition & 1 deletion packages/api-client/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { defineConfig } from 'tsup';
export default defineConfig({
entry: ['src/index.ts'],
format: ['cjs', 'esm'],
dts: true,
dts: false, // emitted via a blocking tsc pass (build script); tsup's concurrent dts intermittently no-ops on Windows CI
clean: true,
sourcemap: true,
});
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"scripts": {
"dev": "tsup --watch",
"build": "tsup",
"build": "tsup && tsc -p tsconfig.build.json",
"lint": "eslint src/**/*.ts",
"test": "vitest run",
"test:watch": "vitest",
Expand Down
14 changes: 14 additions & 0 deletions packages/core/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"emitDeclarationOnly": true
},
"exclude": [
"node_modules",
"dist",
"src/**/*.test.ts",
"src/**/*.test.tsx",
"src/**/*.spec.ts",
"src/**/*.spec.tsx"
]
}
2 changes: 1 addition & 1 deletion packages/core/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { defineConfig } from 'tsup';
export default defineConfig({
entry: ['src/index.ts'],
format: ['cjs', 'esm'],
dts: true,
dts: false, // emitted via a blocking tsc pass (build script); tsup's concurrent dts intermittently no-ops on Windows CI
clean: true,
sourcemap: true,
});
2 changes: 1 addition & 1 deletion packages/crypto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"scripts": {
"dev": "tsup --watch",
"build": "tsup",
"build": "tsup && tsc -p tsconfig.build.json",
"lint": "eslint src/**/*.ts",
"test": "vitest run",
"test:watch": "vitest",
Expand Down
14 changes: 14 additions & 0 deletions packages/crypto/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"emitDeclarationOnly": true
},
"exclude": [
"node_modules",
"dist",
"src/**/*.test.ts",
"src/**/*.test.tsx",
"src/**/*.spec.ts",
"src/**/*.spec.tsx"
]
}
4 changes: 2 additions & 2 deletions packages/crypto/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export default defineConfig([
format: ['cjs'],
clean: true,
sourcemap: true,
dts: true,
dts: false, // emitted via a blocking tsc pass (build script); tsup's concurrent dts intermittently no-ops on Windows CI
// Bundle all dependencies into the CJS output so CommonJS consumers
// (NestJS API, Jest) don't hit ERR_PACKAGE_PATH_NOT_EXPORTED or
// "Unexpected token export" from ESM-only deps (@noble/*, @libp2p/*, ipns, multiformats).
Expand All @@ -16,7 +16,7 @@ export default defineConfig([
entry: ['src/index.ts'],
format: ['esm'],
sourcemap: true,
dts: true,
dts: false, // emitted via a blocking tsc pass (build script); tsup's concurrent dts intermittently no-ops on Windows CI
// ESM output leaves deps external — Vite/browser bundlers handle them natively.
},
]);
2 changes: 1 addition & 1 deletion packages/sdk-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"scripts": {
"dev": "tsup --watch",
"build": "tsup",
"build": "tsup && tsc -p tsconfig.build.json",
"lint": "eslint src/**/*.ts",
"test": "vitest run",
"test:watch": "vitest",
Expand Down
14 changes: 14 additions & 0 deletions packages/sdk-core/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"emitDeclarationOnly": true
},
"exclude": [
"node_modules",
"dist",
"src/**/*.test.ts",
"src/**/*.test.tsx",
"src/**/*.spec.ts",
"src/**/*.spec.tsx"
]
}
2 changes: 1 addition & 1 deletion packages/sdk-core/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { defineConfig } from 'tsup';
export default defineConfig({
entry: ['src/index.ts'],
format: ['cjs', 'esm'],
dts: true,
dts: false, // emitted via a blocking tsc pass (build script); tsup's concurrent dts intermittently no-ops on Windows CI
clean: true,
sourcemap: true,
});
2 changes: 1 addition & 1 deletion packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"scripts": {
"dev": "tsup --watch",
"build": "tsup",
"build": "tsup && tsc -p tsconfig.build.json",
"lint": "eslint src/**/*.ts",
"test": "vitest run",
"test:watch": "vitest",
Expand Down
14 changes: 14 additions & 0 deletions packages/sdk/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"emitDeclarationOnly": true
},
"exclude": [
"node_modules",
"dist",
"src/**/*.test.ts",
"src/**/*.test.tsx",
"src/**/*.spec.ts",
"src/**/*.spec.tsx"
]
}
2 changes: 1 addition & 1 deletion packages/sdk/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { defineConfig } from 'tsup';
export default defineConfig({
entry: ['src/index.ts'],
format: ['cjs', 'esm'],
dts: true,
dts: false, // emitted via a blocking tsc pass (build script); tsup's concurrent dts intermittently no-ops on Windows CI
clean: true,
sourcemap: true,
});
10 changes: 5 additions & 5 deletions release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@
"component": "@cipherbox/api",
"include-component-in-tag": true,
"bump-minor-pre-major": true,
"release-as": "0.39.0"
"release-as": "0.39.1"
},
"apps/web": {
"release-type": "node",
"component": "@cipherbox/web",
"include-component-in-tag": true,
"bump-minor-pre-major": true,
"release-as": "0.43.0"
"release-as": "0.44.0"
},
"apps/desktop": {
"release-type": "node",
Expand Down Expand Up @@ -105,14 +105,14 @@
"component": "@cipherbox/crypto",
"include-component-in-tag": true,
"bump-minor-pre-major": true,
"release-as": "0.32.0"
"release-as": "0.32.1"
},
"packages/api-client": {
"release-type": "node",
"component": "@cipherbox/api-client",
"include-component-in-tag": true,
"bump-minor-pre-major": true,
"release-as": "0.39.0"
"release-as": "0.39.1"
},
"packages/sdk-core": {
"release-type": "node",
Expand All @@ -126,7 +126,7 @@
"component": "@cipherbox/sdk",
"include-component-in-tag": true,
"bump-minor-pre-major": true,
"release-as": "0.35.0"
"release-as": "0.35.1"
},
"crates/crypto": {
"release-type": "rust",
Expand Down
Loading