Skip to content

docs: close two todos resolved by PR #500 and rescope folder-seeding cleanup#502

Merged
FSM1 merged 1 commit into
mainfrom
docs/close-resolved-todos
Jun 16, 2026
Merged

docs: close two todos resolved by PR #500 and rescope folder-seeding cleanup#502
FSM1 merged 1 commit into
mainfrom
docs/close-resolved-todos

Conversation

@FSM1

@FSM1 FSM1 commented Jun 16, 2026

Copy link
Copy Markdown
Owner

What

Housekeeping on .planning/todos/ after verifying each pending todo against live code. Two todos were fully resolved by PR `#500` and one was partially resolved.

Changes

Docs/planning only — no code or CI changes.

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

Note: This release contains internal planning documentation updates related to architectural planning and technical roadmap refinement. No user-facing features or bug fixes are included in this update.

  • Documentation
    • Updated internal planning documentation for cost optimization and SDK consolidation initiatives.

…cleanup

Verified against live code:
- encrypt-share-itemname-at-rest: M1 fixed (item_name_encrypted bytea +
  client ECIES wrap + migration) -> moved to completed
- route-shared-folder-writes-through-the-sdk-client: all 5 shared-write ops
  route through getSdkClient with sharedFolderTree owning publish/sequence/CAS
  -> moved to completed
- remove-redundant-web-folder-seeding: item 1 (ensureFolderRegistered + ~14
  call sites) landed in PR #500; rescoped the todo to the remaining
  useFolderNavigation key-unwrap consolidation

Also stages the modified Phala TEE on-demand cost-reduction seed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Entire-Checkpoint: 824b2fefc43c
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 13e1091d-aef7-4c1d-aa7c-80a6ba42bfe3

📥 Commits

Reviewing files that changed from the base of the PR and between 383e856 and 6f4465f.

📒 Files selected for processing (4)
  • .planning/seeds/SEED-001-phala-tee-on-demand-cost-reduction.md
  • .planning/todos/completed/2026-06-13-encrypt-share-itemname-at-rest.md
  • .planning/todos/completed/2026-06-15-route-shared-folder-writes-through-the-sdk-client.md
  • .planning/todos/pending/2026-06-16-remove-redundant-web-folder-seeding-now-that-sdk-self-bootst.md

Walkthrough

Two planning documents are updated. SEED-001 is expanded from placeholder stubs into a full Phala TEE cost-reduction plan with feasibility analysis, four architecture options, risk-adjusted recommendations, open spikes, and expanded breadcrumbs. A pending todo document is updated to reflect that the ensureFolderRegistered removal is complete and to narrow remaining work to consolidating ECIES key-unwrapping into the SDK.

Changes

Planning Document Updates

Layer / File(s) Summary
SEED-001 Phala TEE cost-reduction enrichment
.planning/seeds/SEED-001-phala-tee-on-demand-cost-reduction.md
Frontmatter is populated with enriched metadata; body is rewritten with TEE workload context, feasibility findings, four architecture options (A–D), risk-adjusted recommendation sequence, surfacing conditions, scope estimate, pre-commit spike questions, and expanded breadcrumbs/notes.
Todo narrowed to ECIES unwrap consolidation
.planning/todos/pending/2026-06-16-remove-redundant-web-folder-seeding-now-that-sdk-self-bootst.md
Problem framing updated to mark ensureFolderRegistered deletion as completed by PR #500; remaining work scoped to eliminating duplicated key-unwrapping in useFolderNavigation by routing through client.ensureFolderLoaded/FolderState; Solution steps rewritten accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • FSM1/cipher-box#70: Implements async subfolder navigation with ECIES key unwrapping and the real loadFolder pipeline — directly the code the todo targets for SDK consolidation.
  • FSM1/cipher-box#489: Modifies ensureFolderRegistered with reconcileFolderState, overlapping with the todo's completed task of removing web-side folder pre-seeding and transferring ownership to the SDK.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main objective of closing completed todos and rescoping remaining work, reflecting the core changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/close-resolved-todos

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

Release Preview

No version bumps detected. All changes are in unversioned paths or use exempt commit types.

@FSM1 FSM1 merged commit d4a7120 into main Jun 16, 2026
17 of 18 checks passed
@FSM1 FSM1 deleted the docs/close-resolved-todos branch June 16, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant