chore(ci): align api-client versions with API and fix OpenAPI versioning#428
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 59 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (129)
📒 Files selected for processing (5)
WalkthroughThe PR synchronizes version numbers across multiple package manifests to 0.35.0, replaces hardcoded API version strings with dynamic environment-variable-based values, and extends release-please configuration to track the OpenAPI specification file for consistent release detection. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Release PreviewNo version bumps detected. All changes are in unversioned paths or use exempt commit types. |
There was a problem hiding this comment.
Pull request overview
Aligns API client package versions and OpenAPI spec versioning with the API package to support cleaner automated releases via release-please.
Changes:
- Bump Node and Rust API client versions to
0.35.0and update the release-please manifest accordingly. - Replace hardcoded OpenAPI version (
0.1.0) with a runtime/generation-time version source. - Configure release-please to bump
packages/api-client/openapi.json’sinfo.versionautomatically onapps/apireleases.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| release-please-config.json | Adds openapi.json version as an apps/api release-please extra file; minor formatting change for desktop extra-files. |
| .release-please-manifest.json | Updates manifest versions for packages/api-client and crates/api-client. |
| packages/api-client/package.json | Bumps @cipherbox/api-client version to 0.35.0. |
| packages/api-client/openapi.json | Updates OpenAPI info.version to 0.35.0. |
| apps/api/src/main.ts | Swagger DocumentBuilder version now reads from npm_package_version env var (with fallback). |
| apps/api/scripts/generate-openapi.ts | OpenAPI generator now reads version from npm_package_version env var (with fallback). |
| crates/api-client/Cargo.toml | Bumps cipherbox-api-client crate version to 0.35.0. |
| Cargo.lock | Updates locked versions consistent with the bumped workspace package versions. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/api/scripts/generate-openapi.ts`:
- Line 210: The call to .setVersion(process.env.npm_package_version || '0.0.0')
should fail fast when process.env.npm_package_version is missing; update the
generator so it first checks process.env.npm_package_version and if falsy throws
an Error (or calls process.exit(1) after logging) with a clear message about the
missing npm_package_version, then pass the validated value into .setVersion(...)
(refer to the .setVersion call and process.env.npm_package_version in the
current generator).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8175a8c6-3b08-462c-9482-ab5fb1466af0
⛔ Files ignored due to path filters (3)
Cargo.lockis excluded by!**/*.lockpackages/api-client/openapi.jsonis excluded by!packages/api-client/**packages/api-client/package.jsonis excluded by!packages/api-client/**
📒 Files selected for processing (5)
.release-please-manifest.jsonapps/api/scripts/generate-openapi.tsapps/api/src/main.tscrates/api-client/Cargo.tomlrelease-please-config.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 62.28% 71.84% +9.55%
==========================================
Files 134 113 -21
Lines 10081 7164 -2917
Branches 1050 1052 +2
==========================================
- Hits 6279 5147 -1132
+ Misses 3586 1801 -1785
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
- Align @cipherbox/api-client (0.33.0 → 0.35.0) and cipherbox-api-client (0.4.0 → 0.35.0) to match the API package version - Fix hardcoded 0.1.0 OpenAPI version: main.ts reads from package.json, generator script fails fast if npm_package_version is missing - Add openapi.json as release-please extra file with jsonpath - Regenerate API client with correct version Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 1dc3ad2cbe7f
2f8f225 to
0157f39
Compare
Summary
@cipherbox/api-client(0.33.0 → 0.35.0) andcipherbox-api-client(0.4.0 → 0.35.0) versions to match the API package0.1.0OpenAPI version — now reads fromnpm_package_versionat runtime and generation timeopenapi.jsonas a release-please extra file so future API releases bump it automaticallyContext
Prepares for bootstrap tagging so release-please PR #427 generates a clean changelog instead of listing the entire commit history.
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Chores