ci: run E2E tests on feature PRs that touch web-relevant paths#393
Conversation
The release gate's "Verify E2E Passed" check was auto-passing for non-release PRs, allowing merges without E2E verification. Now detects web-relevant path changes (apps/web, apps/api, packages, tests/web-e2e) and runs E2E inline via workflow_call before allowing merge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: f606ec90ab79
|
Caution Review failedPull request was closed or merged during review WalkthroughThe pull request modifies the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing — this addresses the wrong problem. The real issue is the release gate not re-triggering when new code lands on main. |
Summary
apps/web/,apps/api/,packages/,tests/web-e2e/) on all PRsworkflow_calltoe2e.ymland gates on the resultHow it works
detect-changesjob now runs a web-path check on all PRs (not just release PRs)run-web-e2ejob callse2e.ymlviaworkflow_callwhen web paths are changed and it's not a release PRverify-e2echecks therun-web-e2eresult for feature PRs instead of auto-passingTest plan
.github/workflows/which doesn't match web patterns, so E2E should skip with "No web-relevant changes"tests/web-e2e/orapps/web/should trigger the full E2E run before merge is allowed🤖 Generated with Claude Code
Summary by CodeRabbit