Skip to content

docs: capture todo for vault key blob IPNS separation#348

Closed
FSM1 wants to merge 1 commit into
mainfrom
chore/add-vault-key-separation-todo
Closed

docs: capture todo for vault key blob IPNS separation#348
FSM1 wants to merge 1 commit into
mainfrom
chore/add-vault-key-separation-todo

Conversation

@FSM1

@FSM1 FSM1 commented Mar 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Captures a high-priority todo for separating the vault key blob from the root folder IPNS name
  • The current v2 blob format conflates rootFolderKey storage with root folder metadata in one IPNS record, causing web root folder publishes to overwrite the key blob with v1 JSON (breaking next login)

Test plan

  • Docs-only change (todo file), no code impact

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added internal planning documentation for an upcoming architectural update to vault initialization and login workflows.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 3753c1b0a245
@coderabbitai

coderabbitai Bot commented Mar 24, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 50bd11a2-058d-43d1-96c5-7567fd74da99

📥 Commits

Reviewing files that changed from the base of the PR and between 6aa4114 and 06c050b.

📒 Files selected for processing (1)
  • .planning/todos/pending/2026-03-24-separate-vault-key-blob-from-root-folder-ipns-name.md

Walkthrough

This pull request adds a planning document that outlines an architectural change to separate vault key blob storage from root folder metadata publication. The design specifies splitting a single IPNS record into two distinct IPNS records with different formats and responsibilities, along with required codebase updates.

Changes

Cohort / File(s) Summary
Planning Documentation
.planning/todos/pending/2026-03-24-separate-vault-key-blob-from-root-folder-ipns-name.md
Adds architectural specification for splitting vault-key IPNS and root-folder IPNS records, detailing updated control flow for initialization, login, and folder mutations across web and desktop clients, along with required codebase changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/add-vault-key-separation-todo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FSM1 FSM1 closed this Mar 24, 2026
@FSM1
FSM1 deleted the chore/add-vault-key-separation-todo branch March 24, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant