chore(ci): fix load test scenario filter and add concurrency guard#340
Conversation
- Call vitest directly instead of via npm script to fix scenario filtering — pnpm's `--` separator causes CAC to put the filter in a separate bucket instead of treating it as a file filter - Add concurrency group per environment so load tests queue instead of running simultaneously (concurrent runs interfere with each other's latency measurements) - Bump timeout from 30 to 60 minutes for high client count runs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: f57ccfc83cff
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe load-test workflow was modified to add concurrency controls preventing in-progress runs from cancellation, increase the job timeout from 30 to 60 minutes, and change the test execution command from a filtered pnpm script to a direct vitest invocation with a different working directory. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
pnpm exec vitest run --no-coverage <scenario>directly instead of going through the npm script with--. pnpm's--separator causes Vitest's CAC CLI parser to put the filter intooptions['--']instead of treating it as a positional file filter — so all 5 scenarios ran instead of just the selected one.load-test-<environment>ensures load tests queue instead of running simultaneously. Concurrent runs against the same staging API interfere with each other's latency measurements.Test plan
mixed-workloadscenario and verify onlymixed-workload.test.tsruns (not all 5)🤖 Generated with Claude Code
Summary by CodeRabbit