Skip to content

fix(docker): use raw byte count for SOMEGUY_LIBP2P_MAX_MEMORY#328

Merged
FSM1 merged 1 commit into
mainfrom
fix/someguy-memory-uint64
Mar 23, 2026
Merged

fix(docker): use raw byte count for SOMEGUY_LIBP2P_MAX_MEMORY#328
FSM1 merged 1 commit into
mainfrom
fix/someguy-memory-uint64

Conversation

@FSM1

@FSM1 FSM1 commented Mar 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • Someguy crash-looping on staging because SOMEGUY_LIBP2P_MAX_MEMORY=1GB is not a valid uint64
  • Fix: use 1073741824 (1GB in bytes)
could not parse "1GB" as uint64 value from environment variable
"SOMEGUY_LIBP2P_MAX_MEMORY" for flag libp2p-max-memory

Test plan

  • Merge and deploy to staging
  • Verify someguy container starts and stays healthy

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated memory configuration values in deployment settings to use explicit byte values for consistency.

The flag expects a uint64 byte count, not a human-readable string.
"1GB" caused someguy to crash-loop on staging with:
  could not parse "1GB" as uint64 value

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 92322d434b8f
@coderabbitai

coderabbitai Bot commented Mar 23, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 057b5d10-f8f6-476f-89db-c73dbac5044e

📥 Commits

Reviewing files that changed from the base of the PR and between ffbdd16 and 958328d.

📒 Files selected for processing (2)
  • docker/docker-compose.staging.yml
  • docker/docker-compose.yml

Walkthrough

Updated the SOMEGUY_LIBP2P_MAX_MEMORY environment variable in two docker-compose configuration files from human-readable format (1GB) to explicit byte notation (1073741824). No logic, control flow, or service configuration changes were made.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
docker/docker-compose.staging.yml, docker/docker-compose.yml
Updated SOMEGUY_LIBP2P_MAX_MEMORY environment variable from 1GB to 1073741824 (byte representation) in both staging and production compose files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: converting SOMEGUY_LIBP2P_MAX_MEMORY from human-readable format to raw byte count, which directly addresses the crash-loop issue described in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/someguy-memory-uint64

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FSM1 FSM1 merged commit 89c11c0 into main Mar 23, 2026
16 checks passed
@FSM1 FSM1 deleted the fix/someguy-memory-uint64 branch March 23, 2026 03:59
This was referenced Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant