Skip to content

chore(docker): someguy monitoring and e2e gitignore cleanup#291

Merged
FSM1 merged 3 commits into
mainfrom
chore/someguy-monitoring-improvements
Mar 19, 2026
Merged

chore(docker): someguy monitoring and e2e gitignore cleanup#291
FSM1 merged 3 commits into
mainfrom
chore/someguy-monitoring-improvements

Conversation

@FSM1

@FSM1 FSM1 commented Mar 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add Alloy Prometheus scrape config for the someguy delegated routing sidecar (port 8190, /debug/metrics/prometheus)
  • Switch someguy healthcheck from wget to curl
  • Gitignore generated e2e test fixture files (tests/e2e/fixtures/files/)
  • Untrack tests/e2e/test-results/.last-run.json (was committed despite gitignore rule)

Test plan

  • Load test ran against staging — 4/5 clients completed full ~70-op workloads successfully
  • Verify someguy metrics appear in Grafana after next staging deploy

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added Prometheus metrics collection for an additional internal service to improve monitoring and observability.
    • Updated a service health check command to be more reliable on failure detection.
    • Adjusted test environment files and cleaned up prior test run artifacts to keep test runs deterministic.

FSM1 and others added 2 commits March 19, 2026 22:36
Add Alloy Prometheus scrape config for the someguy delegated routing
sidecar (port 8190) and switch its healthcheck from wget to curl.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 8aeb991217f5
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 4c29595b8d09
@coderabbitai

coderabbitai Bot commented Mar 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c2b2a57b-2c44-433f-847d-a06fe49e4145

📥 Commits

Reviewing files that changed from the base of the PR and between 5455394 and 6d560a1.

📒 Files selected for processing (1)
  • tests/e2e/.gitignore
✅ Files skipped from review due to trivial changes (1)
  • tests/e2e/.gitignore

Walkthrough

Adds a Prometheus scrape job for someguy:8190, switches the Docker Compose healthcheck to use curl -sf, updates test .gitignore to ignore fixtures/files/* except two files, and removes a stale test results JSON file.

Changes

Cohort / File(s) Summary
Prometheus Monitoring
docker/alloy-config.river
Added prometheus.scrape "someguy" targeting someguy:8190 with metrics_path = "/debug/metrics/prometheus", scrape_interval = "30s", forwarding to prometheus.remote_write.grafana_cloud.receiver.
Docker Compose
docker/docker-compose.staging.yml
Replaced someguy service healthcheck command from `wget -qO- http://localhost:8190/version
Tests / Artifacts
tests/e2e/.gitignore, tests/e2e/test-results/.last-run.json
Added /fixtures/files/* to .gitignore while unignoring .gitkeep and test-image.png; removed tests/e2e/test-results/.last-run.json.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main changes: adding someguy Prometheus monitoring configuration and e2e gitignore cleanup. The title is concise, specific, and directly reflects the primary intent of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/someguy-monitoring-improvements
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docker/docker-compose.staging.yml`:
- Line 100: The healthcheck currently uses curl under the healthcheck 'test'
entry which fails because the image ghcr.io/ipfs/someguy:v0.11.1 is minimal and
lacks curl; replace the 'test' value for the service healthcheck to either a TCP
probe against port 8190 (e.g., use a small TCP check such as nc/socat/timeout
-t0 -c or docker's native CMD-SHELL TCP check) or use wget for an HTTP probe
(e.g., call wget -qO- http://localhost:8190/version >/dev/null) so the
healthcheck runs in the minimal image—update the healthcheck 'test' key
accordingly for the service that exposes port 8190.

In `@tests/e2e/.gitignore`:
- Line 7: The current ignore rule `/fixtures/files/` is too broad and hides
committed static fixtures used by tests (see tests/e2e/utils/test-files.ts and
its use of copyFileSync for files like test-image.png); narrow the rule to only
ignore generated or temp artifacts (e.g., a generated/ or tmp/ subfolder) or add
explicit negation patterns for committed fixtures (e.g., unignore specific
filenames or a committed/ subfolder) so static baseline files remain tracked
while generated files stay ignored.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2b70f08e-5544-4a2b-bbd8-656a104150d8

📥 Commits

Reviewing files that changed from the base of the PR and between 51c22c7 and 5455394.

📒 Files selected for processing (4)
  • docker/alloy-config.river
  • docker/docker-compose.staging.yml
  • tests/e2e/.gitignore
  • tests/e2e/test-results/.last-run.json
💤 Files with no reviewable changes (1)
  • tests/e2e/test-results/.last-run.json

Comment thread docker/docker-compose.staging.yml
Comment thread tests/e2e/.gitignore Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves staging observability and cleans up E2E repository hygiene by adding Prometheus scraping for the someguy delegated routing service and tightening ignored/generated test artifacts.

Changes:

  • Add Grafana Alloy Prometheus scrape job for someguy metrics (/debug/metrics/prometheus on port 8190).
  • Update someguy container healthcheck to use curl instead of wget.
  • Ignore generated E2E fixture files directory and remove a committed Playwright last-run artifact.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
docker/alloy-config.river Adds a new prometheus.scrape job to collect someguy metrics and forward to Grafana Cloud remote_write.
docker/docker-compose.staging.yml Switches someguy healthcheck command to curl for HTTP probing.
tests/e2e/.gitignore Ignores fixtures/files/ to avoid committing generated E2E fixture artifacts.
tests/e2e/test-results/.last-run.json Removes a committed Playwright test-results file that should be ignored.

Keep .gitkeep and test-image.png tracked while ignoring generated files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 503d760a5757
@FSM1 FSM1 merged commit 78b1b3d into main Mar 19, 2026
20 checks passed
@FSM1 FSM1 deleted the chore/someguy-monitoring-improvements branch March 19, 2026 22:10
@codecov

codecov Bot commented Mar 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.24%. Comparing base (c1c96de) to head (6d560a1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   48.13%   48.24%   +0.11%     
==========================================
  Files         109      109              
  Lines        8387     8405      +18     
  Branches      652      653       +1     
==========================================
+ Hits         4037     4055      +18     
  Misses       4177     4177              
  Partials      173      173              
Flag Coverage Δ
api 84.88% <ø> (+0.08%) ⬆️
crypto 84.88% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants