chore(docker): someguy monitoring and e2e gitignore cleanup#291
Conversation
Add Alloy Prometheus scrape config for the someguy delegated routing sidecar (port 8190) and switch its healthcheck from wget to curl. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 8aeb991217f5
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 4c29595b8d09
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds a Prometheus scrape job for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docker/docker-compose.staging.yml`:
- Line 100: The healthcheck currently uses curl under the healthcheck 'test'
entry which fails because the image ghcr.io/ipfs/someguy:v0.11.1 is minimal and
lacks curl; replace the 'test' value for the service healthcheck to either a TCP
probe against port 8190 (e.g., use a small TCP check such as nc/socat/timeout
-t0 -c or docker's native CMD-SHELL TCP check) or use wget for an HTTP probe
(e.g., call wget -qO- http://localhost:8190/version >/dev/null) so the
healthcheck runs in the minimal image—update the healthcheck 'test' key
accordingly for the service that exposes port 8190.
In `@tests/e2e/.gitignore`:
- Line 7: The current ignore rule `/fixtures/files/` is too broad and hides
committed static fixtures used by tests (see tests/e2e/utils/test-files.ts and
its use of copyFileSync for files like test-image.png); narrow the rule to only
ignore generated or temp artifacts (e.g., a generated/ or tmp/ subfolder) or add
explicit negation patterns for committed fixtures (e.g., unignore specific
filenames or a committed/ subfolder) so static baseline files remain tracked
while generated files stay ignored.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2b70f08e-5544-4a2b-bbd8-656a104150d8
📒 Files selected for processing (4)
docker/alloy-config.riverdocker/docker-compose.staging.ymltests/e2e/.gitignoretests/e2e/test-results/.last-run.json
💤 Files with no reviewable changes (1)
- tests/e2e/test-results/.last-run.json
There was a problem hiding this comment.
Pull request overview
This PR improves staging observability and cleans up E2E repository hygiene by adding Prometheus scraping for the someguy delegated routing service and tightening ignored/generated test artifacts.
Changes:
- Add Grafana Alloy Prometheus scrape job for
someguymetrics (/debug/metrics/prometheuson port 8190). - Update
someguycontainer healthcheck to usecurlinstead ofwget. - Ignore generated E2E fixture files directory and remove a committed Playwright last-run artifact.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docker/alloy-config.river |
Adds a new prometheus.scrape job to collect someguy metrics and forward to Grafana Cloud remote_write. |
docker/docker-compose.staging.yml |
Switches someguy healthcheck command to curl for HTTP probing. |
tests/e2e/.gitignore |
Ignores fixtures/files/ to avoid committing generated E2E fixture artifacts. |
tests/e2e/test-results/.last-run.json |
Removes a committed Playwright test-results file that should be ignored. |
Keep .gitkeep and test-image.png tracked while ignoring generated files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 503d760a5757
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 48.13% 48.24% +0.11%
==========================================
Files 109 109
Lines 8387 8405 +18
Branches 652 653 +1
==========================================
+ Hits 4037 4055 +18
Misses 4177 4177
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
/debug/metrics/prometheus)wgettocurltests/e2e/fixtures/files/)tests/e2e/test-results/.last-run.json(was committed despite gitignore rule)Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit