Skip to content

fix: strip trailing slash from GRAFANA_URL#285

Merged
FSM1 merged 1 commit into
mainfrom
fix/grafana-trailing-slash
Mar 7, 2026
Merged

fix: strip trailing slash from GRAFANA_URL#285
FSM1 merged 1 commit into
mainfrom
fix/grafana-trailing-slash

Conversation

@FSM1

@FSM1 FSM1 commented Mar 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Grafana dashboard provisioning failed with HTTP 301 because GRAFANA_URL had a trailing slash, causing a double-slash in the API path (https://host//api/dashboards/db)
  • Adds GRAFANA_URL="${GRAFANA_URL%/}" to defensively strip trailing slashes
  • Also updated the GRAFANA_URL GitHub variable to remove the trailing slash

Context

First run of the provision-dashboard job from PR #282 failed: https://github.com/FSM1/cipher-box/actions/runs/22799652757/job/66139917676

Test plan

  • Merge and trigger a staging deploy — verify provision-dashboard job succeeds with HTTP 200

🤖 Generated with Claude Code

Grafana Cloud returns HTTP 301 when the URL has a double slash
(e.g. https://host//api/...). Strip trailing slash defensively.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 336c8c1a7c7c
@coderabbitai

coderabbitai Bot commented Mar 7, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@FSM1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5ddd1ea3-0fbb-4318-97e8-4619bd120555

📥 Commits

Reviewing files that changed from the base of the PR and between 362e2a9 and 0cbca00.

📒 Files selected for processing (1)
  • .github/workflows/deploy-staging.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/grafana-trailing-slash

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FSM1 FSM1 merged commit 09ced7d into main Mar 7, 2026
19 checks passed
@FSM1 FSM1 deleted the fix/grafana-trailing-slash branch March 7, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant