fix(ci): write WinFsp registry key for winfsp-sys build script

[FSM1]

Summary

• winfsp-sys build.rs reads HKLM\SOFTWARE\WOW6432Node\WinFsp\InstallDir to locate WinFsp headers and libs — there is no env var fallback
• The MSI install doesn't reliably write this registry key on GitHub Actions runners
• Fix: explicitly create the registry key after MSI install, then verify lib/ and inc/ directories exist
• Also removes the WINFSP_INSTALL_DIR env var from the previous PR (fix(ci): fix Windows desktop staging build and add Linux desktop build #232) which winfsp-sys doesn't actually check

Root cause

The winfsp crate's system feature (enabled in Cargo.toml) triggers a registry lookup in winfsp-sys build.rs. CI only runs cargo check/cargo test which use the build-dependency (without system feature, uses bundled libs). The staging tauri build is the first workflow to do a full release build with the system feature.

Test plan

• Merge and tag a new staging release to verify Windows desktop build succeeds

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Improved Windows build setup for staging to detect and validate WinFsp installation and required headers/libs, increasing build reliability.
  • Removed reliance on an explicitly passed install-dir environment variable for the desktop build, relying on validated system location instead.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56caf85 and d109517.

📒 Files selected for processing (1)

• .github/workflows/deploy-staging.yml

---

Walkthrough

Modifies the Windows staging deployment workflow to create/validate a WinFsp registry key and InstallDir, verify expected subdirectories, log the path, and remove the explicit WINFSP_INSTALL_DIR environment variable from the desktop tauri build step.

Changes

Cohort / File(s)	Summary
WinFsp Registry Configuration .github/workflows/deploy-staging.yml	Adds Windows registry manipulation to ensure HKLM\SOFTWARE\WOW6432Node\WinFsp exists and sets InstallDir to C:\Program Files (x86)\WinFsp; validates lib and inc subdirectories and logs the path. Removes the explicit WINFSP_INSTALL_DIR env var from the tauri build step.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix(ci): fix Windows desktop staging build and add Linux desktop build #232: Previously added an explicit WINFSP_INSTALL_DIR fallback for Windows/tauri CI builds; closely related to this PR's alternative registry-based resolution.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding WinFsp registry key manipulation in CI for the winfsp-sys build script.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/winfsp-registry-key

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/deploy-staging.yml:
- Around line 195-198: After reading the registry with Get-ItemProperty into
$regVal, explicitly assert that $regVal and $regVal.InstallDir exist and match
the expected $installDir (instead of only Write-Host); if the registry read
returned $null or InstallDir is empty or not equal to $installDir, throw an
error so the step fails fast. Update the block that uses Get-ItemProperty,
$regVal and the InstallDir checks to validate the retrieved value (and consider
removing -ErrorAction SilentlyContinue) before proceeding to the existing
Test-Path checks for "$installDir\lib" and "$installDir\inc".

---

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c50db68 and 56caf85.

📒 Files selected for processing (1)

• .github/workflows/deploy-staging.yml