fix(ci): symlink FUSE-T pkgconfig as fuse.pc for macOS builds#225
Merged
Conversation
FUSE-T installs its pkgconfig file as fuse-t.pc in a non-standard location (/Library/Application Support/fuse-t/pkgconfig/), but the vendored fuser build.rs probes for "fuse" or "osxfuse". On CI runners without macFUSE, there is no fuse.pc file, causing the build to fail. Fix: after installing FUSE-T, create a symlink from fuse-t.pc to /usr/local/lib/pkgconfig/fuse.pc so pkg-config finds it under the expected name. Applied to all 4 workflow files that install FUSE-T. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: ba5b944ef0de
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
WalkthroughThree GitHub Actions workflow files are modified to enhance macOS FUSE-T installation. Each change replaces a single brew install command with a multi-line script that installs FUSE-T, creates Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fuse-t.pcat/Library/Application Support/fuse-t/pkgconfig/, but the vendored fuserbuild.rsprobes forfuseorosxfusevia pkg-configfuse.pcexists, causing cargo build to failbrew install --cask fuse-t, symlinkfuse-t.pc→/usr/local/lib/pkgconfig/fuse.pcci.yml(×2),e2e-desktop.yml,deploy-staging.ymlTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit